Compose FlowRow, add param for maxRows [293577082]

Fixed

Feature Request

Status Update

No update yet.

Description

co...@protonmail.com

created issue #1

Jul 28, 2023 02:23PM

Sometimes when you're using a flow row you want some control over how many rows will actually be shown. sometimes a designer will also say "this should be the last item" (typically a button that says "show more" or something)

Maybe FlowRow can have this built into it?

Comments

ma...@marcardar.com <ma...@marcardar.com> #2Jul 31, 2023 06:54AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ti...@google.com <ti...@google.com> Aug 2, 2023 01:26AM

Assigned to co...@google.com.

ma...@google.com <ma...@google.com> Aug 2, 2023 12:18PM

Reassigned to uo...@google.com.

uo...@google.com <uo...@google.com> Oct 8, 2023 03:20PM

Accepted by uo...@google.com.

sa...@google.com <sa...@google.com> #3Oct 10, 2023 04:27PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4Feb 13, 2024 03:01PM

deleted

ap...@google.com <ap...@google.com> #5Feb 13, 2024 03:01PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Feb 13, 2024 03:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit fa4ea5b238c4e46144c955ffdf456c1041e61f01
Author: Faithful Uchenna Okoye <uokoye@google.com>
Date: Wed Nov 29 05:54:51 2023

Created samples for FlowRow and ContextualFlowRow with maxLines

Bug: 293577082
Test: Tested in topic
Change-Id: I9c10084c67eb78d24fb23df6ae11db192f230c7c

A compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/ContextualFlowColumnDemo.kt
A compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/ContextualFlowRowDemo.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/LayoutDemos.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/SimpleFlowColumnDemo.kt
M compose/foundation/foundation-layout/integration-tests/layout-demos/src/main/java/androidx/compose/foundation/layout/demos/SimpleFlowRowDemo.kt
A compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/ContextualFlowColumnSample.kt
A compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/ContextualFlowRowSample.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowColumnSample.kt
M compose/foundation/foundation-layout/samples/src/main/java/androidx/compose/foundation/layout/samples/FlowRowSample.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/ContextualFlowLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/FlowLayout.kt
M compose/foundation/foundation-layout/src/commonMain/kotlin/androidx/compose/foundation/layout/FlowLayoutOverflow.kt

https://android-review.googlesource.com/2850142

uo...@google.com <uo...@google.com> Feb 13, 2024 03:04PM

Marked as fixed.

co...@protonmail.com <co...@protonmail.com> #7Feb 13, 2024 05:34PM

amazing! thank you!

uo...@google.com <uo...@google.com> #8Feb 13, 2024 05:47PM

You're very welcome!

pr...@google.com <pr...@google.com> #9Feb 21, 2024 07:33PM