Material3 CenterAlignedTopAppBar with TopAppBarDefaults.pinnedScrollBehavior() color change on scroll [293665988]

Fixed

Bug

Status Update

No update yet.

Description

vi...@gmail.com

created issue #1

Jul 29, 2023 11:25AM

Jetpack Compose BOM version: 2023.06.01
Jetpack Compose component used: CenterAlignedTopAppBar
Android Studio Build: #AI-223.8836.35.2231.10406996
Kotlin version: 1.9.0

Steps to Reproduce or Code Sample to Reproduce:

Here is github link:

https://github.com/vladimirlogachov/MoviesPot/blob/master/app/src/main/java/com/vlohachov/moviespot/ui/movies/upcoming/UpcomingMovies.kt

Video that shows the issue is in attachments.

Screen_recording_20230729_131557.mp4

2.7 MB

Download

Comments

vi...@gmail.com <vi...@gmail.com> #2Dec 11, 2023 10:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@google.com <ma...@google.com> Dec 28, 2023 07:40PM

Reassigned to ma...@google.com.

sg...@google.com <sg...@google.com> #3Jan 2, 2024 09:15PM

Does this happen if you temporarily remove/disable the pull-refresh part?

vi...@gmail.com <vi...@gmail.com> #4Jan 2, 2024 09:23PM

Will check

On Tue, Jan 2, 2024, 22:15 <buganizer-system@google.com> wrote:

- Show quoted text -

vi...@gmail.com <vi...@gmail.com> #5Jan 3, 2024 11:53AM

Here is screen recording with pull refresh removed from grid content modifier. AppBar color animation on scroll no longer blocked, but when I call gridState.scrollToItem(0) by clicking scroll to top button, it's color not changed unless I pull content down manually.

Screen_recording_20240103_124946.mp4

4.9 MB

Download

il...@gmail.com <il...@gmail.com> #6Jul 19, 2024 05:00PM

We're facing the same issue with TopAppBar and TopAppBarDefaults.pinnedScrollBehavior. When scrolling quickly on a lazy layout, the app bar container color does not respond.

Repo: https://github.com/smelfungus/NestedScrollAppBarIssue/tree/master

Video: https://drive.google.com/file/d/1XmJENXecUYq0hAC2xGBvrr2k_XeeXvZe/view?usp=sharing

val scrollBehavior = TopAppBarDefaults.pinnedScrollBehavior()

Scaffold(
    modifier = Modifier
        .fillMaxSize()
        .nestedScroll(scrollBehavior.nestedScrollConnection),
    topBar = {
        TopAppBar(
            title = {
                Text(
                    modifier = Modifier.fillMaxWidth(),
                    text = "Hello!",
                    textAlign = TextAlign.Center,
                )
            },
            scrollBehavior = scrollBehavior,
        )
    },
) { innerPadding ->
    LazyColumn(
        modifier = Modifier.padding(innerPadding),
        contentPadding = PaddingValues(16.dp),
        verticalArrangement = Arrangement.spacedBy(8.dp),
    ) {
        items(100) {
            Text(
                text = "Item $it",
                modifier = Modifier
                    .fillMaxWidth()
                    .background(MaterialTheme.colorScheme.surfaceContainerHigh)
                    .padding(24.dp),
            )
        }
    }
}

to...@gmail.com <to...@gmail.com> #7Oct 11, 2024 08:51AM

I am facing the same bug and i think the root case for it is that the PinnedScrollBehavior doesn't override the onPostFling in its NestedScrollConnection implementation.

I made a crude simple custom version and added

override suspend fun onPostFling(consumed: Velocity, available: Velocity): Velocity {
    if (available.y > Velocity.Zero.y)
        state.contentOffset = 0f

    return super.onPostFling(consumed, available)
}

and then it works fine for me!

sg...@google.com <sg...@google.com> Oct 11, 2024 11:50PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Nov 25, 2024 02:04PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #8Nov 26, 2024 07:50AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3375689

Fix the app-bars behaviors to detect end of scroll

Expand for full commit details

Fix the app-bars behaviors to detect end of scroll 
 
Apply a fix to all the behaviors to detect the end of scroll in the post 
fling function. This will better ensure an app-bar color change when the 
content is scrolled all the way. 
 
Bug: 293665988 
Test: Manual 
Relnote: "Fix the top and bottom app-bar behaviors to reliably change 
color when content is scrolled all the way." 
 
Change-Id: Idc4e834695cbd7cb8099f7b63cf21d5b764f1c81

Files:

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

Hash: 792c8cdf7db425c674de1214e60c7d01f46e9750
Date: Mon Nov 25 06:03:57 2024

sg...@google.com <sg...@google.com> Nov 26, 2024 07:54AM

Marked as fixed.