Fixed

Bug

Status Update

No update yet.

Description

au...@google.com

created issue #1

Jul 31, 2023 05:56PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Apply https://android-review.git.corp.google.com/q/topic:%22agp-8.2.0-alpha14%22 to androidx
ANDROIDX_PROJECTS=INFRAROGUE ./gradlew :collection:collection-benchmark-kmp:lintReportJvm

Expected

Success

Actual

$ ANDROIDX_PROJECTS=INFRAROGUE ./gradlew :collection:collection-benchmark-kmp:lintReportJvm
Configuration on demand is an incubating feature.
Calculating task graph as no configuration cache is available for tasks: :collection:collection-benchmark-kmp:lintReportJvm
> Task :collection:collection-benchmark-kmp:lintReportJvm FAILED

0 problems were found storing the configuration cache.

See the complete report at file:///ssd/ssd5/androidx-main/out/androidx/build/reports/configuration-cache/ez036c4s4k28isyc8z2uv79t4/6bxkh3z3fwbfmohcrvzsjx7c2/configuration-cache-report.html

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':collection:collection-benchmark-kmp:lintReportJvm' (type 'AndroidLintTask').
  - In plugin 'com.android.internal.version-check' type 'com.android.build.gradle.internal.lint.AndroidLintTask' property 'variantInputs.name' doesn't have a configured value.
    
    Reason: This property isn't marked as optional and no value has been configured.
    
    Possible solutions:
      1. Assign a value to 'variantInputs.name'.
      2. Mark property 'variantInputs.name' as optional.
    
    For more information, please refer to https://docs.gradle.org/8.3-rc-1/userguide/validation_problems.html#value_not_set in the Gradle documentation.

https://ge.androidx.dev/s/6blaetrg4uhog

Studio Build: n/a
Version of Gradle Plugin: 8.2.0-alpha14
Version of Gradle: 8.3-rc-1
Version of Java: 17
OS: linux

Comments

sp...@google.com <sp...@google.com> Jul 31, 2023 05:56PM

Assigned to sp...@google.com.

au...@google.com <au...@google.com> #2Jul 31, 2023 05:57PM

One observation here is that ANDROIDX_PROJECTS=INFRAROGUE triggers enabling ok KMP native targets.

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt;l=113?q=INFRAROGUE&ss=androidx%2Fplatform%2Fframeworks%2Fsupport

au...@google.com <au...@google.com> #3Jul 31, 2023 06:02PM

It also repros with ./gradlew :collection:collection-benchmark-kmp:lintReportJvm -Pandroidx.enabled.kmp.target.platforms="+linux"

au...@google.com <au...@google.com> #4Jul 31, 2023 06:05PM

As a side note, it is a bit bad that it says In plugin 'com.android.internal.version-check' type instead of com.android.lint

sp...@google.com <sp...@google.com> #5Aug 1, 2023 07:13PM

Reassigned to au...@google.com.

I see the issue here - the AndroidLintTask is currently assuming that there will be a jvm target named "jvm" 😞.

The best fix will be to fully remove variantInputs as an input to the AndroidLintTask (Issue 290070593), but that is blocked on AndroidX upgrading to AGP 8.2.0-alpha14 or higher 🤦‍♂️ (or else the AGP/AndroidX integration branch will fail).

Can you workaround the issue by either (1) temporarily removing the lint plugin from :collection:collection-benchmark-kmp or (2) adding a fake jvm target named "jvm"? If that allows you to upgrade AGP to 8.2.0-alpha14 and remove AndroidX's usage of the API (similar to aosp/I8fa3fdf4119c0cc4433c0b72f7ad0e0096a6de72), then I can fix this bug by removing variantInputs as an input to the AndroidLintTask.

sp...@google.com <sp...@google.com> #6Aug 1, 2023 10:00PM

Edit: See comment #7 below

~~running grep -rl 'androidXMultiplatform' | xargs grep -L 'jvm()' yields the following list:~~

~~compose/test-utils/build.gradle~~

~~compose/animation/animation/build.gradle~~

~~compose/animation/animation-graphics/build.gradle~~

...

~~collection/collection-benchmark/build.gradle~~

~~collection/collection/build.gradle~~

~~I expect running lint or lintReportJvm on any of these modules will result in a similar failure.~~

Another workaround (in addition to options 1 and 2 listed above) would be to temporarily not run lint or lintReportJvm on those modules (until I'm able to remove variantInputs as an input to the AndroidLintTask.

Message last modified on Aug 2, 2023 05:53AM

sp...@google.com <sp...@google.com> #7Aug 2, 2023 05:57AM

Reassigned to au...@google.com.

Good news, this is not as bad as #6 suggested because those other modules do not apply the standalone lint plugin, so running lint on them still works.

The only AndroidX module that is affected by this bug is the original :collection:collection-benchmark-kmp.

Can we temporarily not run lint on that module to unblock AndroidX from upgrading to AGP 8.2.0-alpha14?

au...@google.com <au...@google.com> #8Aug 3, 2023 04:26PM

Reassigned to sp...@google.com.

Disabling lint on :collection:collection-benchmark-kmp and :benchmark:benchmark-darwin-samples works around it. Assigning it back for the proper fix.

ag...@google.com <ag...@google.com> Aug 4, 2023 11:41AM

Reassigned to an...@google.com.

ga...@google.com <ga...@google.com> Aug 4, 2023 01:25PM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #9Aug 14, 2023 04:59PM

This was fixed in AGP 8.3 branch here.

Cherry-pick to AGP 8.2 pending.

sp...@google.com <sp...@google.com> #10Aug 15, 2023 05:25PM

Marked as fixed.

The fix was cherry-picked to AGP 8.2.0-beta01.

IssueTracker

Android Lint fails on a KMP library with `property 'variantInputs.name' doesn't have a configured value.`

Status Update

Description

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Expected

Actual

Comments

sp...@google.com <sp...@google.com> Jul 31, 2023 05:56PM

au...@google.com <au...@google.com> #2Jul 31, 2023 05:57PM

au...@google.com <au...@google.com> #3Jul 31, 2023 06:02PM

au...@google.com <au...@google.com> #4Jul 31, 2023 06:05PM

sp...@google.com <sp...@google.com> #5Aug 1, 2023 07:13PM

sp...@google.com <sp...@google.com> #6Aug 1, 2023 10:00PM

sp...@google.com <sp...@google.com> #7Aug 2, 2023 05:57AM

au...@google.com <au...@google.com> #8Aug 3, 2023 04:26PM

ag...@google.com <ag...@google.com> Aug 4, 2023 11:41AM

ga...@google.com <ga...@google.com> Aug 4, 2023 01:25PM

sp...@google.com <sp...@google.com> #9Aug 14, 2023 04:59PM

sp...@google.com <sp...@google.com> #10Aug 15, 2023 05:25PM

Issue 293900782

Description

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Expected

Actual

Issue summary

Comments

sp...@google.com <sp...@google.com> Jul 31, 2023 05:56PM

au...@google.com <au...@google.com> #2Jul 31, 2023 05:57PM

au...@google.com <au...@google.com> #3Jul 31, 2023 06:02PM

au...@google.com <au...@google.com> #4Jul 31, 2023 06:05PM

sp...@google.com <sp...@google.com> #5Aug 1, 2023 07:13PM

sp...@google.com <sp...@google.com> #6Aug 1, 2023 10:00PM

sp...@google.com <sp...@google.com> #7Aug 2, 2023 05:57AM

au...@google.com <au...@google.com> #8Aug 3, 2023 04:26PM

ag...@google.com <ag...@google.com> Aug 4, 2023 11:41AM

ga...@google.com <ga...@google.com> Aug 4, 2023 01:25PM

sp...@google.com <sp...@google.com> #9Aug 14, 2023 04:59PM

sp...@google.com <sp...@google.com> #10Aug 15, 2023 05:25PM

Add comment

Issue metadata