Fixed
Status Update
Comments
en...@google.com <en...@google.com>
da...@maxmine.com.au <da...@maxmine.com.au> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@maxmine.com.au <da...@maxmine.com.au> #3
sh...@google.com <sh...@google.com>
da...@maxmine.com.au <da...@maxmine.com.au> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
da...@maxmine.com.au <da...@maxmine.com.au> #6 Restricted
Restricted
Comment has been deleted.
is...@google.com <is...@google.com>
da...@maxmine.com.au <da...@maxmine.com.au> #7
My previous comment giving the steps to replicate the issue appears to have been deleted. I have since forgotten the specifics of the steps, but can share the broad outlines.
- Attached is a PCAP containing a truncated message.
- Replay this PCAP over UDP (using a tool like
https://github.com/ska-sa/udpreplay )
sa...@google.com <sa...@google.com>
sa...@google.com <sa...@google.com> #8
I am able to repro. I can reply with tcpreplay.
tcpreplay -i en0 ~/Downloads/truncated\ mDNS\ packets.pcapng
sa...@google.com <sa...@google.com> #9
It looks like we are not using openscreen
properly. Config
should live as long as the Service is alive. The docs of MdnsResponder and MdnsServiceImpl are explicit.
MdnsResponder:
// |record_handler|, |sender|, |receiver|, |task_runner|, |random_delay|, and
// |config| are expected to persist for the duration of this instance's
// lifetime.
MdnsServiceImpl
// |task_runner|, |reporting_client|, and |config| must exist for the duration
// of this instance's life.
yz...@gmail.com <yz...@gmail.com> #13
daemon not running; starting now at tcp:5037
[Deleted User] <[Deleted User]> #14
Mine has an error with ui nit just the I, not sure how literal this verbose problem is...please keep us updated.....64 arm correct?
mb...@gmail.com <mb...@gmail.com> #15
Hello
se...@gmail.com <se...@gmail.com> #16
Приветствую вас
eb...@gmail.com <eb...@gmail.com> #17
هالو
sp...@gmail.com <sp...@gmail.com> #18
👍🏻
qa...@gmail.com <qa...@gmail.com> #20 Restricted+
Restricted+
Comment has been deleted.
te...@gmail.com <te...@gmail.com> #22
Reda
sa...@gmail.com <sa...@gmail.com> #24
Setup
ab...@gmail.com <ab...@gmail.com> #25
One ui 7.0
wo...@gmail.com <wo...@gmail.com> #26
ga...@gmail.com <ga...@gmail.com> #27
Que bueno que ya está bien
wo...@gmail.com <wo...@gmail.com> #28
Bardzo dobre
wo...@gmail.com <wo...@gmail.com> #29
Zadowolony
kz...@gmail.com <kz...@gmail.com> #30
Scan hacking
pa...@gmail.com <pa...@gmail.com> #31
Please update my best practice
wa...@gmail.com <wa...@gmail.com> #32
Excelente inicio
pa...@gmail.com <pa...@gmail.com> #33
Please update
am...@gmail.com <am...@gmail.com> #34
Done
kw...@gmail.com <kw...@gmail.com> #35
I have been having a lot of problems lately
Get Outlook for Android<https://aka.ms/AAb9ysg >
________________________________
From: buganizer-system@google.com <buganizer-system@google.com>
Sent: Tuesday, January 7, 2025 11:29:46 PM
To: b-system+-1739714008@google.com <b-system+-1739714008@google.com>
Cc: kwamanabrown1@gmail.com <kwamanabrown1@gmail.com>
Subject: Re: Issue 294120933 : ADB crashes with often due to openscreen error
Replying to this email means your email address will be shared with the team that works on this product.
https://issuetracker.google.com/issues/294120933
Changed
am...@gmail.com added comment #34 <https://issuetracker.google.com/issues/294120933#comment34 >:
Done
_______________________________
Reference Info: 294120933 ADB crashes with often due to openscreen error
component: Android Public Tracker > App Development > SDK > platform tools > adb<https://issuetracker.google.com/components/192795 >
status: Fixed
reporter: da...@maxmine.com.au
assignee: sa...@google.com
cc: ad...@google.com, sa...@google.com
type: Bug
access level: Default access
priority: P2
severity: S2
retention: Component default
Generated by Google IssueTracker notification system.
You're receiving this email because you are subscribed to updates on Google IssueTracker issue 294120933 <https://issuetracker.google.com/issues/294120933 > where you have the roles: subscribed
Unsubscribe from this issue.<https://issuetracker.google.com/issues/294120933?unsubscribe=true >
Get Outlook for Android<
________________________________
From: buganizer-system@google.com <buganizer-system@google.com>
Sent: Tuesday, January 7, 2025 11:29:46 PM
To: b-system+-1739714008@google.com <b-system+-1739714008@google.com>
Cc: kwamanabrown1@gmail.com <kwamanabrown1@gmail.com>
Subject: Re:
Replying to this email means your email address will be shared with the team that works on this product.
Changed
am...@gmail.com added
Done
_______________________________
Reference Info: 294120933 ADB crashes with often due to openscreen error
component: Android Public Tracker > App Development > SDK > platform tools > adb<
status: Fixed
reporter: da...@maxmine.com.au
assignee: sa...@google.com
cc: ad...@google.com, sa...@google.com
type: Bug
access level: Default access
priority: P2
severity: S2
retention: Component default
Generated by Google IssueTracker notification system.
You're receiving this email because you are subscribed to updates on Google IssueTracker
Unsubscribe from this issue.<
ma...@gmail.com <ma...@gmail.com> #36
.
as...@gmail.com <as...@gmail.com> #37
tnx
ro...@gmail.com <ro...@gmail.com> #38
Brigadao
hu...@gmail.com <hu...@gmail.com> #39
Add a comment
hu...@gmail.com <hu...@gmail.com> #40
.
si...@gmail.com <si...@gmail.com> #41
Dnnddndn
po...@gmail.com <po...@gmail.com> #42
ไม่มี
en...@google.com <en...@google.com>
sh...@gmail.com <sh...@gmail.com>
al...@gmail.com <al...@gmail.com> #44
حل المشكلات
Description
I'm experiencing frequent adb crashes on my development machine resulting in loss of connection to my android device.
Any suggestions on what may be causing this issue?
The crashes always have this log entry:
I think this log error comes from openscreen here:https://cs.android.com/android/platform/superproject/main/+/main:external/openscreen/discovery/mdns/mdns_responder.cc;l=303?q=max_allowed_messages_&ss=android
About my configuration:
Full log is attached.