IssueTracker

Component used: Navigation

Version used: androidx.navigation:navigation-compose:2.7.0-rc01 (same issue occurs with 2.6.0)

Devices/Android versions reproduced on: Pixel 6 / Android 13

Calling NavController.navigate() { launchSingleTop = true } when using two nested navigations graphs that both contain a node with the same nested route crashes with this stack trace:

type: crash
osVersion: google/oriole/oriole:13/TQ3A.230705.001/2023072600:user/release-keys
package: com.example.navigationtest:1
process: com.example.navigationtest
processUptime: 1300 + 73 ms

java.util.NoSuchElementException: ArrayDeque is empty.
	at kotlin.collections.ArrayDeque.removeLast(ArrayDeque.kt:163)
	at androidx.navigation.NavController.launchSingleTopInternal(NavController.kt:1868)
	at androidx.navigation.NavController.navigate(NavController.kt:1829)
	at androidx.navigation.NavController.navigate(NavController.kt:1792)
	at androidx.navigation.NavController.navigate(NavController.kt:2193)
	at androidx.navigation.NavController.navigate$default(NavController.kt:2188)
	at androidx.navigation.NavController.navigate(NavController.kt:2173)
	at com.example.navigationtest.MainActivityKt$MyNavBar$1$1$1.invoke(MainActivity.kt:81)
	at com.example.navigationtest.MainActivityKt$MyNavBar$1$1$1.invoke(MainActivity.kt:76)
	at androidx.compose.foundation.ClickablePointerInputNode$pointerInput$3.invoke-k-4lQ0M(Clickable.kt:895)
	at androidx.compose.foundation.ClickablePointerInputNode$pointerInput$3.invoke(Clickable.kt:889)
	at androidx.compose.foundation.gestures.TapGestureDetectorKt$detectTapAndPress$2$1.invokeSuspend(TapGestureDetector.kt:255)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)

I have attached a sample project, here's the interesting part of it:

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            MyNavHost()
        }
    }
}

@Composable
fun MyNavHost(navController: NavHostController = rememberNavController()) {
    Scaffold(
        bottomBar = { MyNavBar(navController) }
    ) { innerPadding ->
        NavHost(
            modifier = Modifier.padding(innerPadding),
            navController = navController,
            startDestination = "left",
        ) {
            navigation(
                route = "left",
                startDestination = "foo",
            ) {
                composable(route = "foo") {
                    Text("Left")
                }
            }

            navigation(
                route = "right",
                startDestination = "foo",
            ) {
                composable(route = "foo") {
                    Text("Right")
                }
            }
        }
    }
}

@Composable
fun MyNavBar(navController: NavController) {
    val screens = listOf("left", "right")
    val navBackStackEntry by navController.currentBackStackEntryAsState()
    val currentDestination = navBackStackEntry?.destination

    NavigationBar {
        screens.forEach { screen ->
            val selected = currentDestination?.hierarchy?.any { it.route == screen } == true
            NavigationBarItem(
                icon = { Icon(Icons.Default.Info, contentDescription = "") },
                selected = selected,
                label = { Text("text") },
                onClick = {
                    navController.navigate(screen) {
                        launchSingleTop = true
                    }
                }
            )
        }
    }
}