Cubic anchor/control property naming is weird [294562941]

Fixed

Bug

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Aug 4, 2023 05:14PM

In the current Shapes library, which is in alpha, a recent change to remove PointF types from the API introduced properties in Cubic for the anchor control points:
anchorX0, anchorY0
controlX0, controlY0
controlX1, controlY1
anchorX1, controlY1

The concept behind this naming (specifying anchors, controls, and XY components) is fine. But the placement of XY and 01 is backwards. It is not the 0th X component (eg, anchorX0), but rather the 0th *anchor*, which has an X component.
These should be renamed as follows:
anchor0X, anchor0Y
control0X, control0Y
control1X, control1Y
anchor1X, anchor1Y

Comments

ap...@google.com <ap...@google.com> #2Aug 4, 2023 08:29PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ch...@google.com <ch...@google.com> Aug 4, 2023 10:14PM

Marked as fixed.

na...@google.com <na...@google.com> #3Dec 13, 2023 06:33PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Issue 294562941

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Aug 4, 2023 08:29PM

ch...@google.com <ch...@google.com> Aug 4, 2023 10:14PM

na...@google.com <na...@google.com> #3Dec 13, 2023 06:33PM

Add comment

Issue metadata