AGP 8.1.0 uninstalls app after running instrumented tests - 7.4.2 does not [295039976]

Fixed

Bug

Migrated-Tools-Gradle

Reviewed (L1)

Status Update

No update yet.

Description

go...@vippsmobilepay.com

created issue #1

Aug 9, 2023 12:01PM

```
1. Describe the bug or issue that you're seeing.
AGP 8.1.0 uninstalls app after running instrumented tests - 7.4.2 does not

3. If you know what they are, write the steps to reproduce:
Install a debug variant of your app onto a device.
Run instrumented tests targeted that app.
In AGP < 8.x, the app was kept on the device (expected behavior).
In AGP >= 8.x, the app is uninstalled.

Build: AI-223.8836.35.2231.10406996, 202306290837

AI-223.8836.35.2231.10406996, JRE 17.0.6+0-17.0.6b829.9-10027231x64 JetBrains s.r.o., OS Mac OS X(aarch64) v13.5, screens 3456.0x2234.0, 2560.0x1440.0, 2560.0x1440.0

AS: Giraffe | 2022.3.1
Kotlin plugin: 223-1.8.0-release-345-AS8836.35.2231.10406996
Android Gradle Plugin: 8.1.0
Gradle: 8.1
Gradle JDK: JetBrains Runtime version 17.0.6
NDK: from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: (not found), from PATH: (not found)
```

Comments

ha...@google.com <ha...@google.com> Aug 9, 2023 05:33PM

Assigned to an...@google.com.

lo...@gmail.com <lo...@gmail.com> #2Aug 10, 2023 10:30AM

This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.

ga...@google.com <ga...@google.com> Aug 11, 2023 04:53PM

Reassigned to am...@google.com.

zi...@gmail.com <zi...@gmail.com> #3Aug 14, 2023 12:15PM

Almost 2 months later and this is still broken

am...@google.com <am...@google.com> #4Aug 15, 2023 05:47PM

Reassigned to ya...@google.com.

Since there is no progression, I wanted to share our quick-fix for the issue.

#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages

Message last modified on Aug 31, 2023 02:34PM

al...@truecaller.com <al...@truecaller.com> #5Sep 18, 2023 11:35AM

jb...@google.com What is the update on this?

ke...@gmail.com <ke...@gmail.com> #6Sep 19, 2023 12:05PM

What is the status of this item?

Message last modified on Sep 19, 2023 12:38PM

mi...@gmail.com <mi...@gmail.com> #7Sep 22, 2023 02:41PM

This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.

Message last modified on Sep 22, 2023 02:43PM

sp...@google.com <sp...@google.com> #8Sep 22, 2023 04:21PM

Any ETA on next release?

am...@pspdfkit.com <am...@pspdfkit.com> #9Sep 25, 2023 11:41AM

Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.

ar...@google.com <ar...@google.com> #10Sep 25, 2023 04:14PM

Comfirmed that this seems to still be broken. Can we have an update please?

```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1

(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```

ya...@google.com <ya...@google.com> #11Sep 29, 2023 05:42PM

Marked as fixed.

Hi, is there any update to this issue? Thanks.

Message last modified on Sep 29, 2023 05:42PM

sp...@google.com <sp...@google.com> #12Sep 29, 2023 06:44PM

Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?

an...@google.com <an...@google.com> #13Oct 5, 2023 09:26PM

Yeah, still not fixed --'

go...@gmail.com <go...@gmail.com> #14Oct 6, 2023 09:20AM

Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.

sk...@gmail.com <sk...@gmail.com> #15Oct 6, 2023 09:23AM

Any updates on this? The help for this command clearly states this argument is supported.

je...@google.com <je...@google.com> #16Oct 6, 2023 07:51PM

Has anyone re-tried it? We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt in our Dockerfile back in March of 2021.

lu...@gmail.com <lu...@gmail.com> #17Oct 12, 2023 05:30AM

For what it's worth, I did a quick test with the latest CLI: 11076708 (https://developer.android.com/studio#downloads) on OSX and tried it with a simple:

./sdkmanager --sdk_root="../sdk" --package_file=deps.txt

Deps.txt:

platform-tools
extras;google;instantapps
build-tools;35.0.0-rc3

So perhaps this is now resolved? I haven't tried it with more packages

an...@google.com <an...@google.com> #18Oct 17, 2023 09:52PM

The fixes for this issue are now also available in:

Android Studio Hedgehog | 2023.1.1 RC 1
Android Gradle Plugin 8.2.0-rc01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

ig...@monzo.com <ig...@monzo.com> #19Nov 22, 2023 10:47AM

Tried those both:
Android Studio Hedgehog | 2023.1.1 RC 1
Android Gradle Plugin 8.2.0-rc01

Unfortunately, the app was still removed after running the test.

I've tried even the latest Iguana nightly. Same results.

da...@gmail.com <da...@gmail.com> #20Dec 6, 2023 07:31AM

Checked on Android Studio Hedgehog | 2023.1.1.
The issue is reproduced.

Message last modified on Dec 6, 2023 01:48PM

dm...@gmail.com <dm...@gmail.com> #21Dec 6, 2023 04:38PM

I updated Android Gradle Plugin to 8.2.0 and added "android.injected.androidTest.leaveApksInstalledAfterRun=true" to gradle.properties.
It solved the problem!
woho!
thx!

sh...@gmail.com <sh...@gmail.com> #22Dec 19, 2023 02:03AM

Same here.
Updated AGP to 8.2
Added "android.injected.androidTest.leaveApksInstalledAfterRun=true" to gradle.properties
Now the app is not uninstalled after running my Unit testing.

Thanks

sh...@gmail.com <sh...@gmail.com> #23Dec 20, 2023 11:01PM

Arriana A. usman

On Tue, Dec 19, 2023, 10:04 AM <buganizer-system@google.com> wrote:

- Show quoted text -

mg...@gmail.com <mg...@gmail.com> #24Feb 2, 2024 08:41AM

If I understand correctly, don't instrumented tests have at least 2 APKs? One for the app, and one for the test runner? Can we configure AGP to uninstall the test runner but not the app?