IssueTracker

I'm pretty far from being a C++ expert, but I think this may be due to holding a reference to the Config beyond it's lifetime?

See StartDiscovery(): https://cs.android.com/android/platform/superproject/main/+/main:packages/modules/adb/client/transport_mdns.cpp;drc=2c73f5abdf31943e12c68e75f8148c10d2abbf6a;l=154?q=transport_mdns.cpp&ss=android

void StartDiscovery() {
    ...

    g_state->task_runner->PostTask([]() {
        //  optional<Config> created here
        auto config = GetConfigForAllInterfaces();
        if (!config) {
            return;
        }

        // long-lived reference of config given to OpenScreen
        g_state->service = discovery::CreateDnsSdService(g_state->task_runner.get(),
                                                         g_state->reporting_client.get(), *config);

        for (int i = 0; i < kNumADBDNSServices; ++i) {
            auto receiver = std::make_unique<ServiceReceiver>(
                    g_state->service.get(), kADBDNSServices[i], OnServiceReceiverResult);
            receiver->StartDiscovery();
            
            ...
        }

       ...

       // config destructed here
    });
}

A word on impact:

• We rely on WiFi debugging because we use the USB port for additional devices.
• This has made WiFi based debugging unreliable and painful to use because when ADB crashes the connection is lost and is not automatically re-created. Often it can required manually toggling WiFi debugging on the tablet.

Have made a PR: https://android-review.googlesource.com/c/platform/packages/modules/adb/+/2909778

My previous comment giving the steps to replicate the issue appears to have been deleted. I have since forgotten the specifics of the steps, but can share the broad outlines.

1. Attached is a PCAP containing a truncated message.
2. Replay this PCAP over UDP (using a tool like https://github.com/ska-sa/udpreplay)

I am able to repro. I can reply with tcpreplay.

tcpreplay -i en0 ~/Downloads/truncated\ mDNS\ packets.pcapng

It looks like we are not using openscreen properly. Config should live as long as the Service is alive. The docs of MdnsResponder and MdnsServiceImpl are explicit.

MdnsResponder:

 // |record_handler|, |sender|, |receiver|, |task_runner|, |random_delay|, and
  // |config| are expected to persist for the duration of this instance's
  // lifetime.

MdnsServiceImpl

  // |task_runner|, |reporting_client|, and |config| must exist for the duration
  // of this instance's life.

Fixed in aosp/2909778

Eihafmryelhafmaree@gmail.com

Eihafmryelhafmaree@gmail.com

daemon not running; starting now at tcp:5037

Mine has an error with ui nit just the I, not sure how literal this verbose problem is...please keep us updated.....64 arm correct?

bugreport-X692-GL-QP1A.190711.020-2024-10-18-14-13-07.zip

navarretesergio404@gmail.com

Reda

https://issuetracker.google.com/294120933#attachment46070672

Bardzo dobre

Zadowolony

Scan hacking

Please update my best practice

Excelente inicio

Please update

Done

tnx

Brigadao

Add a comment

.

Dnnddndn

https://www.earntp.com/m/h1jze

حل المشكلات

rdrs-user-guide-requestors-21jan25-ar.pdf

I have observed this problem continually for around half a year or so on my old Pixel 5. I am also seeing it on my brand new Pixel 8. Searching for nearby places is enabled in the phone settings, and the location permission for the phone application is set to "when in use". Nevertheless, the phone app search results only show my contacts.

Please check for this issue on the latest beta build and share the new bugreport, If the issue persists.

Yes, still not fixed, December 2023 update. Pixel 8, EU version.

They are not going to fix it. The feature is being removed according to the 9to5Google:

https://9to5google.com/2024/02/02/google-phone-nearby-places/?fbclid=IwAR3fGWKvd2k1G0--5R8i9vSdHzDPUH4S-rCGQFLyAWSiuJrvKWCM6GXuFdM

Google's reason for removing the feature is that nobody uses it. No surprise no one uses it since the feature has not worked for at least a year.

Hi everyone, in the coming months this feature will be winding down, thus closing this bug. More details can be found here -- https://support.google.com/phoneapp/thread/256590014/

Also pasting the linked post directly here in case helpful:

In the coming months, the "Nearby Places" feature in the Phone by Google app will be deprecated. This feature allowed business name search queries entered into the Phone app to provide local business phone number results beyond just your personal contacts. We’ve found only a very small number of people use this feature, and the vast majority of users go to Google Search or Maps when seeking business-related phone numbers; those experiences also provide richer results and contact info for those businesses.

We’re sunsetting this feature so that our team can focus on building the highest quality, most reliable, and most innovative experiences in phone calling. For example, in 2023 we launched new Call Screen AI features, Hold For Me and Direct My Call support in additional countries, and Call Screen transcripts on your Pixel Watch. There’s a lot more planned for 2024, and our team will be working hard throughout the year to launch and improve even more ways to help your phone calling experience!

For existing users of Nearby Places in the Phone by Google app, you can easily fulfill the same needs by typing a local business name into Google Search or Google Maps, which provides even more helpful information beyond phone numbers, such as address/directions, website info, and more.