Assert failure in libopenscreen [295599086]

Fixed

Bug

Status Update

No update yet.

Description

sa...@google.com

created issue #1

Aug 12, 2023 12:24AM

Reported by emil.lenngren@gmail.com in b/217251994.

Comments

sa...@google.com <sa...@google.com> #2Aug 12, 2023 12:24AM

Update: I was going to write Gradle 5.6.2 instead of just 5.6. Sorry for the mistake.

sa...@google.com <sa...@google.com> #3Aug 12, 2023 12:27AM

I was able to find the actual "STRING_TOO_LARGE" occurrence using:

aapt2 dump xmltree --file res/drawable-anydpi-v24/ic_my_vector_image.xml app-debug.apk

But it was possible because the app has already crashed and the stacktrace was pointing to the resource ID so I knew which file I should look for.
I think there should be some way to use AAPT and find all such resources containing "STRING_TOO_LARGE" instead of waiting for the app to crash first.

sa...@google.com <sa...@google.com> #4Aug 12, 2023 12:48AM

Reassigned to mf...@google.com.

Mark, do you have any idea where this could be coming from?

mf...@google.com <mf...@google.com> #5Aug 15, 2023 05:25PM

It's possible that something on the network is sending a type that's not in our enum list. I can put up a patch for cherrypicking.

sa...@google.com <sa...@google.com> #6Aug 15, 2023 06:04PM

Could be. I was assuming there would be a filter somewhere in openscreen to prevent the enum from being generated if it is not a recognized type.

mf...@google.com <mf...@google.com> #7Aug 15, 2023 08:48PM

Landed https://chromium-review.googlesource.com/c/openscreen/+/4779901 which should fix the assertion. Feel free to cherrypick into your own repo/branch (not sure if you can directly from our Gerrit or not).

sa...@google.com <sa...@google.com> #8Aug 15, 2023 09:28PM

I imported it in aosp/2710897. I need your +2.

By the way, there is no OWNERS file, does Gerrit fallsback on the AUTHORS or COMMITTERS list to pick who needs to +2.

mf...@google.com <mf...@google.com> #9Aug 15, 2023 09:56PM

That code review link is giving me a "500 server error" after I tried to log in. I may not have access, unfortunately. Can someone else on your team +2?

mf...@google.com <mf...@google.com> #10Aug 17, 2023 04:43PM

I got access to the cherry-pick, but it looks like the AOSP presubmits are failing. Can you reassign this to yourself to land the CP since I've already landed a fix upstream?

sa...@google.com <sa...@google.com> #11Aug 17, 2023 05:54PM

Reassigned to sa...@google.com.

Sorry, I should have notified you that I already attempted to cherry-pick it (aosp/2710897), I did not expect you to take it all the way to cherry pick in our repo :) !

It looks like we have a tool to use to import external libs (https://cs.android.com/android/platform/superproject/+/master:tools/external_updater/README.md) and it does not support git submodules yet. I will take it from here, thanks!

sa...@google.com <sa...@google.com> Oct 10, 2023 11:02PM

Marked as fixed.