Material / Material3 Linear and Circular Progress Indicators Recompose instead of Redraw on Progress updates [295616656]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 12, 2023 02:51AM

Similar issues were discovered in Lottie several months ago, but also prevalent in `CircularProgressIndicator` and `LinearProgressIndicator` APIs. Indeterminate progress doesn't have the same issue.

When there are animated updates to progress for UIs like "Instagram Stories" or "Google Photos" which are frequent this becomes a problem.

Ideally, these APIs should have a parameter for `progressProvider: () -> Float` instead of just `progress: Float`.

This actively impacts some card types on Play's Apps and Games Home pages.

Comments

jb...@google.com <jb...@google.com> #2Aug 12, 2023 02:52AM

Status is still Assigned, but Compose 1.1.0 was already released. Did the ETA change for this feature?

jb...@google.com <jb...@google.com> #3Aug 21, 2023 04:29PM

The Compose Animation APIs Navigation needs (such as AnimatedContent) are still @Experimental in Compose 1.1.0.

co...@google.com <co...@google.com> Aug 21, 2023 06:01PM

Assigned to ma...@google.com.

ys...@google.com <ys...@google.com> #4Aug 22, 2023 08:59AM

Update: Same case for Compose 1.2.0

ae...@google.com <ae...@google.com> #5Aug 30, 2023 12:19AM

why is this taking so long?

le...@google.com <le...@google.com> #6Aug 30, 2023 03:44AM

seriously no update on what is stable?

jb...@google.com <jb...@google.com> #7Aug 30, 2023 03:51AM

AnimatedContent is, as of today, still experimental and still cannot be used in androidx.navigation.

As soon as it is stable, we can kick off this work.

ys...@google.com <ys...@google.com> #8Aug 31, 2023 03:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit a3386225c952c42b7c687771ea31642d76f4df66
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 11:26:59 2023

Add Preview support in animated NavHost

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Change-Id: I7b017913d96e31785f16eb66534321d05f29b53d

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584844

ma...@google.com <ma...@google.com> Sep 26, 2023 10:47PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #9Sep 28, 2023 07:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 256f919c6b8d579bc55e19d829aed438422f463b
Author: Clara Fok <clarafok@google.com>
Date: Wed May 10 10:48:32 2023

Migrate accompanist NavHost and NavController into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavHost and NavController now supports navigating in compose with Animations."
Change-Id: Ica95e794ef1794df4d1bdb38719b55624f832868

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/public_plus_experimental_current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostControllerTest.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2584843

jb...@google.com <jb...@google.com> #10Sep 28, 2023 08:01PM

Project: platform/frameworks/support
Branch: androidx-main

commit 682bae8ada2b2b29376003d55455230ff7320a69
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 15:13:14 2023

Migrate accompanist NavGraphBuilder into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "NavGraphBuilder now supports building composables and NavGraphs with transition animations."
Change-Id: I5ca9e22c8c3b02acaf80ddaa35b58ba7426c993a

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt

https://android-review.googlesource.com/2584842

pr...@google.com <pr...@google.com> #11Oct 18, 2023 08:41PM

Project: platform/frameworks/support
Branch: androidx-main

commit 895c4bb35ee11fe1c54f538699a845ddfaf7e2eb
Author: Clara Fok <clarafok@google.com>
Date: Tue May 09 13:14:10 2023

Migrate accompanist ComposeNavigator into androidx

Test: ./gradlew navigation:navigation-compose:cC
Bug: 197140101
Relnote: "ComposeNavigator now supports Destinations with Animations."
Change-Id: Ie33b4c2da53ff6c89494332a06be8123be67e879

M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt

https://android-review.googlesource.com/2584841