AGP 8.1.0: dynamic feature: Implicit dependency between exportReleaseConsumerProguardFiles and extractProguardFiles cause compilation errors [295666695]

Fixed

Bug

Status Update

No update yet.

Description

mk...@opera.com

created issue #1

Aug 13, 2023 04:08PM

Compilation of dynamic feature fails because of the implicit dependency between exportReleaseConsumerProguardFiles and extractProguardFiles tasks.

A problem was found with the configuration of task ':dynamicfeature:exportReleaseConsumerProguardFiles' (type 'ExportConsumerProguardFilesTask').
  - Gradle detected a problem with the following location: '/Users/mkubiczek/workspace/threekk/agpissue/dynamicfeature/build/intermediates/default_proguard_files/global/proguard-android-optimize.txt-8.1.0'.

    Reason: Task ':dynamicfeature:exportReleaseConsumerProguardFiles' uses this output of task ':dynamicfeature:extractProguardFiles' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.

    Possible solutions:
      1. Declare task ':dynamicfeature:extractProguardFiles' as an input of ':dynamicfeature:exportReleaseConsumerProguardFiles'.
      2. Declare an explicit dependency on ':dynamicfeature:extractProguardFiles' from ':dynamicfeature:exportReleaseConsumerProguardFiles' using Task#dependsOn.
      3. Declare an explicit dependency on ':dynamicfeature:extractProguardFiles' from ':dynamicfeature:exportReleaseConsumerProguardFiles' using Task#mustRunAfter.

    For more information, please refer to https://docs.gradle.org/8.2/userguide/validation_problems.html#implicit_dependency in the Gradle documentation.

STEPS TO REPRODUCE:

Create an Android Project with AGP 8.1.0
Add dynamic feature module
Try to compile

Removing the following block from the gradle file helps

proguardFiles(
    getDefaultProguardFile("proguard-android-optimize.txt"),
    "proguard-rules.pro"
)

Version of Gradle Plugin: 8.1.0 Version of Gradle: 8.2 Version of Java: 17 OS: MacOS Ventura 13.4.1

Comments

sm...@google.com <sm...@google.com> Aug 14, 2023 08:30AM

Assigned to an...@google.com.

ga...@google.com <ga...@google.com> Aug 15, 2023 06:07PM

Reassigned to hu...@google.com.

hu...@google.com <hu...@google.com> #2Aug 17, 2023 12:34PM

I'm not able to reproduce this issue with the latest Android Studio and AGP previews. Could you attach a sample project that shows this issue?

mk...@opera.com <mk...@opera.com> #3Aug 17, 2023 07:22PM

Sure, check the attached archive. Just run assembleRelease.

r8issue.zip

435 KB

Download

hu...@google.com <hu...@google.com> #4Aug 18, 2023 10:38AM

Thanks, I'm able to reproduce this issue now (in addition to the steps in comment #1, also need to set isMinifyEnabled = true in app).

je...@google.com <je...@google.com> Sep 22, 2023 04:38PM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #5Sep 23, 2023 10:15PM

Accepted by je...@google.com.

FIP : Ica7d8b5acd19137d523f9be0e29fd2f8d0b5fc56

Even after this will get fixed, you will still have an issue that you should not specify the default proguard files in the dynamic feature module. Instead it must be specified on the base module.

thanks for reporting and the repro case !

je...@google.com <je...@google.com> Oct 30, 2023 09:36PM

Marked as fixed.

an...@google.com <an...@google.com> #6Nov 2, 2023 09:04PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 12
Android Gradle Plugin 8.3.0-alpha12

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

hu...@google.com <hu...@google.com> #7Jan 17, 2024 04:50AM

FYI, I just filed Issue 320588676 - "Proguard-related issues in dynamic feature template" to improve our dynamic feature template which could have helped avoid these issues entirely.