Fixed
Status Update
No update yet.
Comments
ya...@google.com
bo...@google.com
ke...@netflix.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
bo...@google.com
zh...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
sy...@syntezzz.ru
It's very annoying bug since it's the only reliable way to detect foldable devices according to
https://android-developers.googleblog.com/2023/06/detecting-if-device-is-foldable-tablet.html#:~:text=If%20a%20device%20has%20a%20hinge%20sensor%20(which%20can%20be%20determined%20by%20PackageManager.hasSystemFeature(PackageManager.FEATURE_SENSOR_HINGE_ANGLE))%2C%20then%20the%20device%20supports%20folding%20in%20some%20manner .
bo...@google.com
thanks for reporting this issue;
the fix will be available in upcoming VIC developer preview images.
the fix will be available in upcoming VIC developer preview images.
bo...@google.com
to clarify
this is fixed on api 35, latest version;
it is not fixed on api 34, will try to back port.
this is fixed on api 35, latest version;
it is not fixed on api 34, will try to back port.
ja...@google.com
Comment has been deleted.
ki...@gmail.com
Usp
ki...@gmail.com
تصØÙŠØ Ø£Ø®Ø·Ø§Ø¡ usp
wh...@gmail.com
Welcome forever welcome
ch...@gmail.com
ch...@gmail.com
0947192161
ch...@gmail.com
CHECK
ch...@gmail.com
ch...@gmail.com Restricted+
Restricted+
Comment has been deleted.
ch...@gmail.com Restricted
Restricted
Comment has been deleted.
Description
Android Studio Version: Giraffe | 2022.3.1
Emulator Version (Emulator--> Extended Controls--> Emulator Version): 32.1.14-10330179
HAXM / KVM Version: HVF 13.5.0
Android SDK Tools: 26.1.1
Host Operating System: macOS 13.5
CPU Manufacturer: Other CPU:
64-bit CPU
RAM: 16384 MB
GPU:
Build Fingerprint:
AVD Details: Name: Pixel_C_Tablet_API_33
CPU/ABI: arm64
Path: /Users/tomas/.android/avd/Pixel_C_API_33.avd
Target: google_apis [Google APIs] (API level 33)
Skin: 2560x1800
SD Card: 512 MB
AvdId: Pixel_C_Tablet_API_33
PlayStore.enabled: false
avd.ini.displayname: Pixel C Tablet API 33
avd.ini.encoding: UTF-8
disk.dataPartition.size: 6G
fastboot.chosenSnapshotFile:
fastboot.forceChosenSnapshotBoot: no
fastboot.forceColdBoot: no
fastboot.forceFastBoot: yes
hw.accelerometer: yes
hw.arc: false
hw.audioInput: yes
hw.battery: yes
hw.camera.back: virtualscene
hw.camera.front: emulated
hw.cpu.ncore: 4
hw.dPad: no
hw.device.hash2: MD5:b6f369a5174fab4bbf46015b0d842ec6
hw.device.manufacturer: Google
hw.gps: no
hw.gpu.enabled: yes
hw.gpu.mode: auto
hw.initialOrientation: landscape
hw.keyboard: yes
hw.lcd.density: 320
hw.lcd.height: 1800
hw.lcd.width: 2560
hw.mainKeys: no
hw.ramSize: 1536
hw.sdCard: yes
hw.sensors.orientation: yes
hw.sensors.proximity: yes
hw.trackBall: no
image.sysdir.1: system-images/android-33/google_apis/arm64-v8a/
runtime.network.latency: none
runtime.network.speed: full
showDeviceFrame: no
skin.dynamic: yes
skin.path.backup: /Users/tomas/Library/Android/sdk/skins/pixel_c
tag.display: Google APIs
vm.heapSize: 192
Steps to Reproduce Bug:Call PackageManager.hasSystemFeature(PackageManager.FEATURE_SENSOR_HINGE_ANGLE) and this method returns true on Pixel C tablet.
Expected Behavior:
Returns false on Pixel C tablet.
Observed Behavior: