Fixed
Status Update
Comments
se...@google.com <se...@google.com>
ke...@google.com <ke...@google.com>
ke...@google.com <ke...@google.com>
ke...@google.com <ke...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
pr...@google.com <pr...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
Description
Jetpack Compose version: 1.5.0
Jetpack Compose component used: material3: 1.1.1
Android Studio Build: Android Studio Giraffe | 2022.3.1
Kotlin version: 1.9.0
In our scenario, we open a ModalBottomSheet in order to edit or submit payment card details. We need to prevent the contents of the sheet from being screenshot, recorded, etc. For that purpose we typically set WindowManager.LayoutParams.FLAG_SECURE flag on a parent's activity's window. This work fine for regular composables, but not for bottomSheets.
Steps to Reproduce or Code Sample to Reproduce:
I suspect that the responsible code resides in ModalBottomSheetWindow class and it's params that are not considering the parent activity's flags and/or does not allow to specify the flags. Also,
type = WindowManager.LayoutParams.TYPE_APPLICATION_PANEL
might play some role, as the panel is AFAIK placed in a different window above the application.I was able to prevent screenshots/recording from happening by adding another view to the WindowManager in a similar manner to what ModalBottomSheetWindow is doing in it's show() function, only with the proper flag being set and making a sub_panel, to be placed above the bottomSheet.