IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support
Branch: androidx-main

commit 5dd0781ddeb7d345cab1cd97bd041e6d178642c6
Author: Rahul Ravikumar <rahulrav@google.com>
Date:   Mon Aug 28 14:10:01 2023

    Sanitize trace names.
   
    Test: ./gradlew :benchmark:benchmark-benchmark:cAT && ./gradlew :benchmark:benchmark-macro:cAT
    Bug: 296453339
   
    ```
    /storage/emulated/0/Android/media/androidx.compose.integration.macrobenchmark/TrivialStartupBenchmark_startup_startup_WARM_compilation_Partial_baselineProfile_UseIfAvailable_iterations_0__iter000_2023_08_28_21_11_51.perfetto_trace
    ```
   
    Change-Id: I36016289b17d657d87a6d5c0bfc25aca83b86f50

M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/OutputsTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ProfilerTest.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Outputs.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt

https://android-review.googlesource.com/2729281

Project: platform/frameworks/support
Branch: androidx-main

commit a4c4bb416d1a231eb874ed8cd48999ccc77ecbf5
Author: Chris Craik <ccraik@google.com>
Date:   Tue Sep 05 14:41:43 2023

    Use sanitized filename as inst result key
   
    Bug:296453339
    Test: ParameterizedBenchmark # fails with new require() block, without fix
   
    Fixes errors in parsing keys containing '=', which leads to significant filename collision in CI, and missing traces.
   
    Change-Id: Ia72c6cea174ad5602fbabafd9d310f6dba3314a8

M       benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Outputs.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/ResultWriter.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoCaptureWrapper.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M       benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MethodTracing.kt

https://android-review.googlesource.com/2741117

Project: platform/frameworks/support
Branch: androidx-main

commit 0023956cafcfd113afa3f89ed31d155ccda4914a
Author: Chris Craik <ccraik@google.com>
Date:   Tue Oct 03 13:43:51 2023

    Avoid over-sanitizing filenames breaking BP plugin file filtering
   
    Fixes:303034735
    Bug:296453339
    Test: OutputTest
    Relnote: "Fix Benchmark file output to no longer break BaselineProfile
    Plugin file copying. Files were generated and copied off device, but
    had been renamed such that the gradle plugin wouldn't see them."
   
    The previous change to fix b/296453339 sanitized filenames to avoid
    certain characters (e.g. the equals sign which caused issues in CI /
    instrumentation result reporting), but unintentionally broke a load
    bearing assumption between BPGP and the Benchmark library.
   
    This wasn't caught in testing because continuous test are on either
    the host side or device side, and don't cover the exchange of files in
    between.
   
    To workaround this coverage gap for now, added a test to OutputTest to
    cover the BPGP filtering - duplicating the filtering that BPGP does to
    look for baseline and startup profiles.
   
    Change-Id: I8dbccc5a11b4c391169cff6dfbd2a0001fd41001

M       benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/tasks/CollectBaselineProfileTask.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/OutputsTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/PerfettoTraceTest.kt
M       benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ProfilerTest.kt
M       benchmark/benchmark-common/src/main/java/androidx/benchmark/Outputs.kt
M       benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/MacrobenchmarkScopeTest.kt

https://android-review.googlesource.com/2768511