IssueTracker

Update: It seems that something is very wrong there, because when I downgraded Firebase to implementation platform('com.google.firebase:firebase-bom:32.0.0'), a similar error happened at a completely different place:

> Task :app:minifyReleaseWithR8 FAILED
ERROR: /home/<redacted>/.gradle/caches/transforms-3/5e9dc6f747814a530f3ab1a07bd31f02/transformed/material-1.9.0-runtime.jar: R8: com.android.tools.r8.internal.Tb: Undefined value encountered during compilation. This is typically caused by invalid dex input that uses a register that is not defined on all control-flow paths leading to the use.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:minifyReleaseWithR8'.
> A failure occurred while executing com.android.build.gradle.internal.tasks.R8Task$R8Runnable
   > Compilation failed to complete, position: Lcom/google/android/material/internal/ManufacturerUtils;unwrapPosition(Landroidx/recyclerview/widget/RecyclerView$Adapter;Lcom/h6ah4i/android/widget/advrecyclerview/draggable/DraggableItemWrapperAdapter;Ljava/lang/Object;ILcom/caverock/androidsvg/CSSParser$Ruleset;)I, origin: /home/<redacted>/.gradle/caches/transforms-3/5e9dc6f747814a530f3ab1a07bd31f02/transformed/material-1.9.0-runtime.jar:com/google/android/material/internal/ManufacturerUtils.class

This time the source code of Material Components for Android is available, and thatManufacturerUtils class doesn't have such a method or reference those classes at all. Maybe something wrong with class merging etc?

The actual unwrapPosition() method is probably com.h6ah4i.android.widget.advrecyclerview.utils.WrapperAdapterUtils#unwrapPosition(androidx.recyclerview.widget.RecyclerView.Adapter, androidx.recyclerview.widget.RecyclerView.Adapter, java.lang.Object, int) from here.

I tested 8.1.60 and this still fails.

Then I tested dev tags and found that build is fixed by something between 8.2.14-dev and 8.2.15-dev.

However, the APKs built with 8.2.15-dev, 8.2.21-dev and 8.3.1-dev are all failing with VerifyError during runtime:

FATAL EXCEPTION: main
Process: me.zhanghai.android.files, PID: 9596
java.lang.VerifyError: Verifier rejected class x3.p4: int x3.p4.x(l1.x0, y6.g, java.lang.Object, int, m2.k) failed to verify: int x3.p4.x(l1.x0, y6.g, java.lang.Object, int, m2.k): [0x2F] args to if-eq/if-ne (Reference: l1.x0,Imprecise Constant: -128) must both be references or integral (declaration of 'x3.p4' appears in /data/app/~~K-diqAnjAPpWs7OV0XyRGw==/me.zhanghai.android.files-Cp7CvgB8vCz3Yx8zuMLrww==/base.apk)
	at x3.p4.d(SourceFile:1)
	at o5.i.<init>(SourceFile:191)
	at j5.g.<init>(SourceFile:365)
	at j5.g.f(SourceFile:40)
	at j5.g.e(SourceFile:1)
	at com.google.firebase.provider.FirebaseInitProvider.onCreate(Unknown Source:11)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2451)
	at android.content.ContentProvider.attachInfo(ContentProvider.java:2421)
	at com.google.firebase.provider.FirebaseInitProvider.attachInfo(SourceFile:13)
	at android.app.ActivityThread.installProvider(ActivityThread.java:7462)
	at android.app.ActivityThread.installContentProviders(ActivityThread.java:6973)
	at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6744)
	at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2133)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7872)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

So right now there's still no way to get a working optimized APK.

Update: This issue can be worked around by turning off R8 full mode (or downgrading to AGP 7.x which doesn't enable R8 full mode by default). Still, it would be nice if the app can use R8 full mode.

If you want to reproduce this issue, please locally revert https://github.com/zhanghai/MaterialFiles/commit/1ae5a81d3203b624b8d9f5eadf2b567deedfbefa

Thanks for reporting the issue and for the reproduction project. It reproduces locally with the update. I'll post back once I have more info on the issue.

This issue is due to an error when R8 does redundant field load elimination. There is a corner case where the field values may cause simplifications of values to be replaced and that results in stale references to values that have been optimized out. I'll post back info once we have a fix on our release branches.

Thanks again for reporting this issue and for the reproduction. A fix has landed on each of the R8 release branches, so you can update your config to the version suitable for your AGP release. Let us know if any issues remain.

I can confirm that both build time error and run time VerifyError is fixed on API 21 and API 33 emulators, with tag 8.3.2-dev which includes the fix:

    repositories {
        ...
        maven {
            url = uri("https://storage.googleapis.com/r8-releases/raw")
        }
    }
    dependencies {
        classpath 'com.android.tools:r8:8.3.2-dev'
        ...
    }

Do you know when this fix will make it into a stable release?

The fix did not make it for the AGP 8.1.1 point release, so it would first be included if another point release is made. It will be the stable release of 8.2 when that is cut.

Also, the fix is on the R8 release branches so you can use the one that matches your AGP instead of using our -dev branch which is not very stable.

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

• Android Studio Giraffe | 2022.3.1 Patch 2
• Android Gradle Plugin 8.1.2

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

It seems to me that this variant is more acceptable, but I am not completely sure to argue it