OOM errors when converting ART Method traces to Perfetto trace format [296905344]

Fixed

Bug

Status Update

No update yet.

Description

ra...@google.com

created issue #1

Aug 21, 2023 07:30PM

Device

Wembley API 30

ATI

https://android-build.corp.google.com/test_investigate/? invocationId=I55400010188736982&testResultId=TR08828870406152874&tab=artifacts

Logcat

https://android-bug-tool.corp.google.com/bug_tool/?url=https://android-build.googleplex.com/builds/I55400010188736982/git_rvc-release/6869500/MetricTests/inv_13890474244675783025/device_logcat_test_046891199W110982_2760524775517217867.txt&source=ABDX

Example Thread Dump

08-18 01:51:31.185 10155  4550  4569 I .benchmark.tes: Waiting for a blocking GC Alloc
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes: "Instr: androidx.benchmark.junit4.AndroidBenchmarkRunner" prio=5 tid=17 Runnable
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   | group="main" sCount=0 dsCount=0 flags=0 obj=0x12c408d0 self=0x9f7f3000
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   | sysTid=4600 nice=-8 cgrp=default sched=0/0 handle=0x7cfa11c0
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   | state=R schedstat=( 55451599723 310843318 3218 ) utm=5382 stm=161 core=0 HZ=100
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   | stack=0x7ce9e000-0x7cea0000 stackSize=1040KB
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   | held mutexes= "mutator lock"(shared held)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.ArtTrace$PerfettoVmTraceParser.addMethodAction(ArtTrace.kt:159)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parseMethodTraceData(VmTraceParser.java:324)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parseData(VmTraceParser.java:248)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parse(VmTraceParser.java:63)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.ArtTrace.toPerfettoTrace(ArtTrace.kt:48)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.MethodTracing.embedInPerfettoTrace(Profiler.kt:204)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.Profiler$ResultFile.embedInPerfettoTrace(Profiler.kt:64)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.BenchmarkState.report(BenchmarkState.kt:524)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.junit4.BenchmarkRule$applyInternal$$inlined$Statement$1.evaluate(BenchmarkRule.kt:372)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:136)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.test.ext.junit.runners.AndroidJUnit4.run(AndroidJUnit4.java:162)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.Suite.runChild(Suite.java:128)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.Suite.runChild(Suite.java:27)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:65)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:471)
08-18 01:51:31.227 10155  4550  4600 W .benchmark.tes:   at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2205)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes: "Instr: androidx.benchmark.junit4.AndroidBenchmarkRunner" prio=5 tid=17 Runnable
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   | group="main" sCount=0 dsCount=0 flags=2 obj=0x12c408d0 self=0x9f7f3000
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   | sysTid=4600 nice=-8 cgrp=default sched=0/0 handle=0x7cfa11c0
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   | state=R schedstat=( 55460571877 310889472 3262 ) utm=5382 stm=162 core=0 HZ=100
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   | stack=0x7ce9e000-0x7cea0000 stackSize=1040KB
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   | held mutexes= "mutator lock"(shared held)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.ArtTrace$PerfettoVmTraceParser.addMethodAction(ArtTrace.kt:159)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parseMethodTraceData(VmTraceParser.java:324)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parseData(VmTraceParser.java:248)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.VmTraceParser.parse(VmTraceParser.java:63)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.vmtrace.ArtTrace.toPerfettoTrace(ArtTrace.kt:48)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.MethodTracing.embedInPerfettoTrace(Profiler.kt:204)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.Profiler$ResultFile.embedInPerfettoTrace(Profiler.kt:64)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.BenchmarkState.report(BenchmarkState.kt:524)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.benchmark.junit4.BenchmarkRule$applyInternal$$inlined$Statement$1.evaluate(BenchmarkRule.kt:372)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.test.rule.GrantPermissionRule$RequestPermissionStatement.evaluate(GrantPermissionRule.java:136)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.test.ext.junit.runners.AndroidJUnit4.run(AndroidJUnit4.java:162)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.Suite.runChild(Suite.java:128)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.Suite.runChild(Suite.java:27)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:65)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:471)
08-18 01:51:31.229 10155  4550  4600 W .benchmark.tes:   at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2205)

Comments

ap...@google.com <ap...@google.com> #2Aug 22, 2023 09:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Aug 25, 2023 09:47PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9e395ebd5dd7ee85b491fc975456493dd0183e2b
Author: Chris Craik <ccraik@google.com>
Date: Fri Aug 25 13:18:03 2023

Fully stream method trace to perfetto file

Test: ArtTraceTest
Test: LazyListScrollingBenchmark#scrollProgrammatically_newItemComposed # method tracing enabled for 20 iterations
Fixes: 296905344

Change drastically reduces resident memory when appending method trace
to perfetto, as we save less, and evict trace data periodically.

Now we appear to be able to safely write up to 600K methods, may now
be constrained by method trace file format.

Relnote: "Fix OOM crash when converting ART method trace -> perfetto
format."

Change-Id: I106bdf99084af10f26a4503b02ae74b9eef8add0

M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/vmtrace/ArtTrace.kt

https://android-review.googlesource.com/2728493

na...@google.com <na...@google.com> #4Sep 20, 2023 07:15PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-common:1.2.0-rc01

Issue 296905344