Provide a way to customize the size Transform in Compose Navigation [296912651]

Fixed

Feature Request

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Aug 21, 2023 08:31PM

Now that we have integrated `AnimatedContent` into AndroidX Navigation, it might be reasonable to allow for custom `sizeTransform` that is passed to the internal `AnimatedContent` of the NavHost.

How exactly we want to take that variable, is not yet clear, but it could be something read at the destination level as part of the enter destination's transition.

Comments

sz...@gmail.com <sz...@gmail.com> #2Sep 16, 2023 08:46PM

Comment has been deleted.

Message last modified on Sep 16, 2023 08:47PM

cs...@gmail.com <cs...@gmail.com> #3Sep 16, 2023 08:47PM

since it is already marked as deprecated, we can probably do it by now.

jb...@google.com <jb...@google.com> #4Sep 18, 2023 02:06PM

Opening diff shortly

na...@vitruvian.me <na...@vitruvian.me> #5Sep 19, 2023 07:23AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

cs...@gmail.com <cs...@gmail.com> #6Sep 19, 2023 08:07AM

I still see the animation as well exactly the way #5 described and displayed in the video with contentaligment topstart, or center, having NavHost with fillMaxSize() modifier or without it.

cs...@twoupdigital.com <cs...@twoupdigital.com> #7Sep 20, 2023 10:21AM

I forgot to mention that in our case this weird animation happens only when we have conditional navigation applied to the start destination. If we just display the content without navigating right after arrival to the destination then all is good.
I attached a very small repro project to the issue which was marked as duplicate (

https://issuetracker.google.com/issues/297824100).
Would you please take a second look at it, and if you deem that it's still working as expected, would you consider providing a way to navigate conditionally with compose that doesn't have the result that is displayed in this issue and ours?

Thanks!

da...@gmail.com <da...@gmail.com> #8Dec 22, 2023 12:39AM

contentAlignment = Alignment.TopStart on the NavHost does not fix the issue. On the contrary, it makes it worse. If my animation is sliding from right to left, instead of animating steadily and centered, it now "curves up" towards the top start and it looks very strange.

Removing contentAlignment = Alignment.TopStart makes the screen that's coming in look more correct, but the screen that's leaving the composition moves around (it looks like it tries to slide down?).

This is a very major bug with very severe visual consequences. I'm shocked this isn't being given more priority.

jb...@google.com <jb...@google.com> Jan 25, 2024 07:17PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #9Feb 16, 2024 02:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit c9745b96364f8b4c4d8bb85d7dbc8652f7cb62d8
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 18 01:37:07 2024

Support sizeTransform for Navigation Compose

Adding support for passing a SizeTransform to a composable or navigation
function when building the NavGraph. This will allow developers to
specify the SizeTransform for a specfic destination.

Note the sizeTransform is determined by the target destination, which is
normally the destination that runs the enter and popEnter transitions
and the default value is `null`.

RelNote: "You can now specify the `SizeTranform` for your transitions in
Navigation Compose by defining them as part of the initialization for
the `composable` and/or `navigation` functions."
Test: work in progress
Bug: 296912651

Change-Id: I91062221a47601b40ced80dc1a31f170351e9f5a

M navigation/navigation-compose/api/current.txt
M navigation/navigation-compose/api/restricted_current.txt
M navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/NavigationDemos.kt
A navigation/navigation-compose/integration-tests/navigation-demos/src/main/java/androidx/navigation/compose/demos/SizeTransformDemo.kt
A navigation/navigation-compose/samples/src/main/java/androidx/navigation/compose/samples/SizeTransformSample.kt
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostScreenShotTest.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavGraphNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/ComposeNavigator.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavGraphBuilder.kt
M navigation/navigation-compose/src/main/java/androidx/navigation/compose/NavHost.kt

https://android-review.googlesource.com/2916066

jb...@google.com <jb...@google.com> #10Feb 16, 2024 03:48PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.8.0-alpha04 release.

na...@google.com <na...@google.com> #11Mar 6, 2024 07:49PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-compose:2.8.0-alpha04