Fixed
Status Update
No update yet.
Comments
ma...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit aa570cc4c23d8aed5f9c704171a6fb58d3f58652
Author: marian <ymarian@google.com>
Date: Wed Aug 30 10:03:42 2023
[ColorScheme] Make color scheme immutable
Test: existing tests
Bug: 297212873
Relnote: """
ColorScheme is now Immutable, making individual color updates less efficient, but making more common usage of colors more efficient
The reasoning behind this change is that the majority of apps wouldn't have updating individual colors as a main use case.
This is still possible but it will recompose more than before, in turn we significantly decrease the amount of state subscriptions through all of material code and will impact initialization and runtime cost of more standard use cases.
"""
Change-Id: Ic447d95734c3399733c49f4b6d018ec296fc251a
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ColorScheme.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/MaterialTheme.kt
https://android-review.googlesource.com/2733678
Branch: androidx-main
commit aa570cc4c23d8aed5f9c704171a6fb58d3f58652
Author: marian <ymarian@google.com>
Date: Wed Aug 30 10:03:42 2023
[ColorScheme] Make color scheme immutable
Test: existing tests
Bug: 297212873
Relnote: """
ColorScheme is now Immutable, making individual color updates less efficient, but making more common usage of colors more efficient
The reasoning behind this change is that the majority of apps wouldn't have updating individual colors as a main use case.
This is still possible but it will recompose more than before, in turn we significantly decrease the amount of state subscriptions through all of material code and will impact initialization and runtime cost of more standard use cases.
"""
Change-Id: Ic447d95734c3399733c49f4b6d018ec296fc251a
M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ColorScheme.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/MaterialTheme.kt
ma...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-alpha08androidx.compose.material3:material3-android:1.2.0-alpha08
Description
This means that if we update one of these colors, we would end up recomposing more, but it means that _a lot_ of material code ends up getting a lot more efficient. I think this is a tradeoff worth making
More details can be found in aosp/2723634