Refactor ColorScheme to be stateless / immutable [297212873]

Fixed

Task

Status Update

No update yet.

Description

le...@google.com

created issue #1

Aug 23, 2023 05:11PM

We currently have every color of ColorScheme backed by a snapshot state object. We should consider making the entire object be stateless and just an immutable bag of color fields.

This means that if we update one of these colors, we would end up recomposing more, but it means that _a lot_ of material code ends up getting a lot more efficient. I think this is a tradeoff worth making

More details can be found in aosp/2723634

Comments

ma...@google.com <ma...@google.com> Aug 29, 2023 05:21PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2Sep 13, 2023 05:08PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ma...@google.com <ma...@google.com> Sep 13, 2023 07:17PM

Marked as fixed.

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Issue 297212873

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Aug 29, 2023 05:21PM

ap...@google.com <ap...@google.com> #2Sep 13, 2023 05:08PM

ma...@google.com <ma...@google.com> Sep 13, 2023 07:17PM

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

Add comment

Issue metadata