IssueTracker

Respectfully in regards to marking this duplicate. It is not quite a duplicate. That referenced ticket is part of SafeArgs, while this request is for typesafe navigation. It was marked as "infeasible", yet w'ere talking about two completely different bases.

In the last comment:

This requires support for doubles in NavInflater whose values are all backed by the TypedValue class, which unfortunately does not support Double values so we cannot go forward with this.

When in fact this is trivial to implement in compose typesafe navigation and seems to be a major omission:

object DoubleNavType : NavType<Double>(isNullableAllowed = false) {
    @Suppress("DEPRECATION")
    override fun get(bundle: Bundle, key: String): Double = bundle[key] as Double

    override fun parseValue(value: String): Double {
        // At runtime the d suffix is optional, contrary to the Safe Args plugin.
        // This is in order to be able to parse double numbers passed as deep link URL
        // parameters
        var localValue = value
        if (value.endsWith("d")) {
            localValue = localValue.substring(0, value.length - 1)
        }
        return localValue.toDouble()
    }

    override fun put(bundle: Bundle, key: String, value: Double) {
        bundle.putDouble(key, value)
    }
}

/**
 * Convience class to allow for double navigation types by turning them into strings and back.
 */
object NullableDoubleNavType : NavType<Double?>(isNullableAllowed = true) {
    @Suppress("DEPRECATION")
    override fun get(bundle: Bundle, key: String): Double? = bundle[key] as? Double?

    override fun parseValue(value: String): Double? {
        if (value == "null") return null
        return DoubleNavType.parseValue(value)
    }

    override fun put(bundle: Bundle, key: String, value: Double?) {
        if (value == null) {
            bundle.putSerializable(key, null)
        } else {
            DoubleNavType.put(bundle, key, value)
        }
    }
}

// in a route 
typeOf<Double>() to DoubleNavType,
typeOf<Double?>() to NullableDoubleNavType,

Similar to the work done in b/351994237 to expand the types supported by Navigation Compose Safe Args to support anything @Serializable can support, I think we can do something similar here to support doubles.

sad674274@gmail.com

DoubleArray support added in https://android-review.googlesource.com/c/platform/frameworks/support/+/3266717

Fixed internally and will be available in navigation 2.8.2.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.annotation:annotation-wasm-js:1.9.0-rc01
• androidx.annotation:annotation-watchosdevicearm64:1.9.0-rc01
• androidx.navigation:navigation-common:2.8.2
• androidx.navigation:navigation-runtime:2.8.2

The following release(s) address this bug.It is possible this bug has only been partially addressed:

• androidx.navigation:navigation-common:2.9.0-alpha01

Over to Jeremy for plans regarding releasing future versions of navigation.

Another way to reproduce the issue between 2.7.0 (works) and 2.7.1 (broken) is a simple slideIntoContainer and slideOutOfContainer navigation. Hit the button in the example below fast and you'll see animations flying in from the corner instead of sliding!! (btw tested 2.7.5 and its still broken)

class MainActivity : ComponentActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            MaterialTheme {
                val navController = rememberNavController()
                NavHost(navController = navController, startDestination = "first_screen") {

                    composable(
                        route = "first_screen",
                        enterTransition = {
                            slideIntoContainer(
                                towards = AnimatedContentTransitionScope.SlideDirection.Left,
                            )
                        },
                        exitTransition = {
                            slideOutOfContainer(
                                towards = AnimatedContentTransitionScope.SlideDirection.Left,
                            )
                        },
                    ) {
                        FirstScreen {
                            navController.navigate("first_screen")
                        }
                    }

                }
            }
        }
    }
}

@Composable
fun FirstScreen(navigate: () -> Unit) {
    Column(
        modifier = Modifier.fillMaxSize(),
        verticalArrangement = Arrangement.Center,
        horizontalAlignment = Alignment.CenterHorizontally
    ) {

        Button(onClick = {
            navigate()
        }) {
            Text(text = "Navigate!")
        }
    }
}

In 2.7.1 we provided a fix for this issue to ensure Navigation works correctly with Scaffold. Unfortunately, there was a layout bug that was fixed in androidx.compose.ui:ui:1.6.0-alpha03, but since it added new APIs it cannot be backported into a point release of Compose 1.5.x.

Once compose 1.6.0 is stable, we can bump the dependency and release a new version of Navigation with the fix, but until then you can resolve it by either bumping your own compose dependency to use 1.6.x or continuing to use Navigation 2.7.0 if you don't need any of the fixes from the other Navigation point releases.

Navigation 2.8.0-alpha01 has upgraded the Compose dependency to 1.7.0-alpha01 so this will be addressed in the next release.

Since compose 1.6.0 is live can we have a fix for that?

We have the same issue (Compose 1.6.2 and Navigation-Compose 2.7.6).

After explicitly setting the enter and exit transitions, I noticed that on some screens it was working correctly, on others it wasn't. The nav destination screens working correctly were calling the .fillMaxSize() modifier on the outermost/topmost Composable in the view composition hierarchy.

So the accidental/unwanted scale animation seems to have something to do with the sizing of the view children during layouting.

Instead of now having to add sizing modifiers to all destination Composables/screens, adding the .fillMaxSize() modifier to the NavHost itself does the trick. As a result, the specified enter and exit transitions are never overriden by whatever causes the bug.

    NavHost(
        modifier = Modifier.fillMaxSize(),
        navController = navController,
        startDestination = navController.currentBackStackEntry?.destination?.route ?: ProfileDestination.Overview.route(),
        enterTransition = { fadeIn(animationSpec = tween(200)) },
        exitTransition = { fadeOut(animationSpec = tween(200)) }
    )

We observe the same behaviour as described in the previous comment – if size of the NavHost was not zero and changing as a result of navigation, we can see weird left slide-in animation. So I doubt this issue is fixed

Please make sure you've updated to the recently released Navigation 2.8.0-alpha04 and file a new issue if you are still seeing any issues - commenting here will not get your issue fixed.