IssueTracker

Hi, Is there any workaround for this issue without having to downgrade? We have upgraded accompanist and if we would downgrade to 2.6.0 it would affect much of our code base.

2.7.0 works well, so you don't have to downgrade al the way to 2.6.0

I don't see any size/scale change using the snippet in comment #1 with tip of tree compose libs. See screen recording attached.

I was able to repro the issue with the project linked in comment #1.

It seems to me like a layout issue that was recently fixed, as the issue is fixed if I use a later version of the ui lib: implementation("androidx.compose.ui:ui:1.6.0-alpha03") or newer.

Please consider adding navigation to the compose BOM. Or at least when there's a stable release of the navigation library make sure it works well with the latest compose BOM. Updating the stable minor version of the navigation library should not break anything.

Thanks for the info btw, I've decided to stay at 2.7.0-beta02 for now, since I know that works in my project and I am not comfortable with updating my compose ui to some alpha version

Over to Jeremy for plans regarding releasing future versions of navigation.

Another way to reproduce the issue between 2.7.0 (works) and 2.7.1 (broken) is a simple slideIntoContainer and slideOutOfContainer navigation. Hit the button in the example below fast and you'll see animations flying in from the corner instead of sliding!! (btw tested 2.7.5 and its still broken)

class MainActivity : ComponentActivity() {

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        setContent {
            MaterialTheme {
                val navController = rememberNavController()
                NavHost(navController = navController, startDestination = "first_screen") {

                    composable(
                        route = "first_screen",
                        enterTransition = {
                            slideIntoContainer(
                                towards = AnimatedContentTransitionScope.SlideDirection.Left,
                            )
                        },
                        exitTransition = {
                            slideOutOfContainer(
                                towards = AnimatedContentTransitionScope.SlideDirection.Left,
                            )
                        },
                    ) {
                        FirstScreen {
                            navController.navigate("first_screen")
                        }
                    }

                }
            }
        }
    }
}

@Composable
fun FirstScreen(navigate: () -> Unit) {
    Column(
        modifier = Modifier.fillMaxSize(),
        verticalArrangement = Arrangement.Center,
        horizontalAlignment = Alignment.CenterHorizontally
    ) {

        Button(onClick = {
            navigate()
        }) {
            Text(text = "Navigate!")
        }
    }
}

In 2.7.1 we provided a fix for this issue to ensure Navigation works correctly with Scaffold. Unfortunately, there was a layout bug that was fixed in androidx.compose.ui:ui:1.6.0-alpha03, but since it added new APIs it cannot be backported into a point release of Compose 1.5.x.

Once compose 1.6.0 is stable, we can bump the dependency and release a new version of Navigation with the fix, but until then you can resolve it by either bumping your own compose dependency to use 1.6.x or continuing to use Navigation 2.7.0 if you don't need any of the fixes from the other Navigation point releases.

Navigation 2.8.0-alpha01 has upgraded the Compose dependency to 1.7.0-alpha01 so this will be addressed in the next release.

Since compose 1.6.0 is live can we have a fix for that?

We have the same issue (Compose 1.6.2 and Navigation-Compose 2.7.6).

After explicitly setting the enter and exit transitions, I noticed that on some screens it was working correctly, on others it wasn't. The nav destination screens working correctly were calling the .fillMaxSize() modifier on the outermost/topmost Composable in the view composition hierarchy.

So the accidental/unwanted scale animation seems to have something to do with the sizing of the view children during layouting.

Instead of now having to add sizing modifiers to all destination Composables/screens, adding the .fillMaxSize() modifier to the NavHost itself does the trick. As a result, the specified enter and exit transitions are never overriden by whatever causes the bug.

    NavHost(
        modifier = Modifier.fillMaxSize(),
        navController = navController,
        startDestination = navController.currentBackStackEntry?.destination?.route ?: ProfileDestination.Overview.route(),
        enterTransition = { fadeIn(animationSpec = tween(200)) },
        exitTransition = { fadeOut(animationSpec = tween(200)) }
    )

We observe the same behaviour as described in the previous comment – if size of the NavHost was not zero and changing as a result of navigation, we can see weird left slide-in animation. So I doubt this issue is fixed

Please make sure you've updated to the recently released Navigation 2.8.0-alpha04 and file a new issue if you are still seeing any issues - commenting here will not get your issue fixed.