Status Update
Comments
ma...@google.com <ma...@google.com>
be...@google.com <be...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
ma...@google.com <ma...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
be...@google.com <be...@google.com> #4
It normally does but I just thought I could quickly get this one done. If it doesn't land I will just mark it as needing triage again.
ma...@google.com <ma...@google.com> #5
No worries, had the exact same thought and hence assigned to myself and started working on similar CL to yours, unaware that you are putting yours together. LGTM, so let's keep it going and hopefully get Meet/Messaging team unblocked. :)
ap...@google.com <ap...@google.com> #6
Branch: androidx-main
commit 839b7c17d3954bc0aedc66771cbda4e378ede041
Author: Ben Trengrove <bentrengrove@google.com>
Date: Thu Aug 24 09:04:13 2023
Add Modifier.preferKeepClear()
Allows marking a Composable as preferring to keep clear of floating windows via
the View.preferKeepClearRects API introduced in API 33.
Example usage:
MyComposable(Modifier.preferKeepClear())
Test: PreferKeepClearTest
Fixes: 297260115
Relnote: "Add Modifier.preferKeepClear() to mark as composable as preferring to keep clear of floating windows
on API 33 and above."
Change-Id: Ib51d57d785da1e0503f26604819ba7d29940e052
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/PreferKeepClearTest.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/PreferKeepClear.kt
A compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/RectListNode.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/SystemGestureExclusion.kt
pr...@google.com <pr...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.6.0-alpha05
androidx.compose.foundation:foundation-android:1.6.0-alpha05
Description
Views added an API in 33 to mark the bounds of the view to be clear from floating windows. We should add support for this in Compose so you can mark a composable as clear from floating windows e.g.
MyComposable(Modifier.preferKeepClear())
View API:https://developer.android.com/reference/android/view/View#setPreferKeepClearRects(java.util.List%3Candroid.graphics.Rect%3E)