Predictive back gesture leads to fragments not being initialized/resumed correctly [297379023]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Aug 24, 2023 06:09PM

Component used: Fragment

Version used: 1.7.0-alpha03

Devices/Android versions reproduced on: Pixel 6 with Android 14

The short summary of the issue is that once the predictive back gesture is completed (or started and canceled only), the fragments seem to be stacked on top of each other, with the top one displaying its contents without being interactive and the bottom one handling the touch input, which leads to crashes and unexpected behavior.

I've attached a minimal sample project to reproduce and describe the issues:

Navigate through the app and its two fragments without using the back gesture: everything works as expected.
On the second fragment, use the back gesture to navigate back to the first fragment. Then tap on the overflow menu: the app crashes unexpectedly with an IndexOutOfBoundsException in FragmentManager.
Relaunch the app and on the second fragment, start the back gesture but cancel it. Then tap on the overflow menu of the second fragment: it doesn't react anymore. Move slightly left with the finger and tap again to open the menu: this time it opens and the toast says "First fragment", which means the touch input is handled by the first fragment and contents are displayed by the second one. Now pause the app by moving it to the background, then resume it: the contents are fully gone and the overflow menu of the first fragment can still be opened by tapping on the top right corner (but slightly left of it because the overflow menu of the second fragment seems to cover the first). Using the back gesture will bring you back to the first fragment, which is then again acting as described in step 2.
Repeat step 3 without pausing the app, then tap on the disabled(!) "Go to second fragment" button of the second fragment: the app crashes with an IllegalArgumentException because the touch input is again handled by the first fragment and it's (enabled!) top button, so the executed navigation transaction (first to second fragment with the second currently displayed) is obviously illegal.

Hope you guys can fix that for the next alpha, thanks for your amazing work! :)

test-predictive.zip

115 KB

Download

Comments

il...@google.com <il...@google.com> Aug 24, 2023 06:28PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Aug 31, 2023 02:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit b697d397d051f91a6f6ed95a55af421f048f3c89
Author: Sanura Njaka <sanura@google.com>
Date: Wed Aug 02 12:16:12 2023

Folding lifecycle-livedata-core-ktx back into main
module

Now that Lifecycle tests are written in kotlin, LiveDataTest
can be moved from lifecycle-livedata-core-ktx into LiveDataTest
within the main lifecycle-livedata-core module.

Test: ./gradlew bOS
Bug: 274800183
Change-Id: I98806ad751bd674a554de665e0e16bf05d67900d

D lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.kt

https://android-review.googlesource.com/2690010

jb...@google.com <jb...@google.com> #3Sep 5, 2023 03:02PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023

Folding lifecycle-livedata-ktx back into main
module

Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.

RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a

M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt

https://android-review.googlesource.com/2695173

pr...@google.com <pr...@google.com> #4Sep 6, 2023 07:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023

Moving ScopesRule into util package

ScopesRule.kt will now be included in lifecycle-livedata's util package

Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955

M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt

https://android-review.googlesource.com/2721674

pa...@gmail.com <pa...@gmail.com> #5Sep 7, 2023 04:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024

Move `lifecycle-viewmodel-ktx` source to the base module

* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.

RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d

A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle

https://android-review.googlesource.com/2930010

an...@gmail.com <an...@gmail.com> #6Jun 20, 2024 08:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024

Move `lifecycle-livedata-core-ktx` source to the base module

* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.

RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668

A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt

https://android-review.googlesource.com/2927827

ho...@myrealtrip.com <ho...@myrealtrip.com> #7Oct 15, 2024 03:10AM

Comment has been deleted.

Message last modified on Oct 15, 2024 03:11AM

ha...@gmail.com <ha...@gmail.com> #8Oct 15, 2024 03:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit ce705f9552422d5cccd145244b3402fbade2768f
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Mon Feb 12 15:13:37 2024

Move `lifecycle-runtime-ktx-lint` to base module

* Rename `lifecycle-runtime-ktx-lint` to `lifecycle-runtime-lint`.
* Move `lintPublish` from obsolete `lifecycle-runtime-ktx` to `lifecycle-runtime`.

Bug: 274800183
Test: manual
Change-Id: I83bc2787fb3636b32e772f100bb8733793829708

M lifecycle/lifecycle-runtime-ktx/build.gradle
M lifecycle/lifecycle-runtime-lint/build.gradle
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleRuntimeIssueRegistry.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/LifecycleWhenChecks.kt
M lifecycle/lifecycle-runtime-lint/src/main/java/androidx/lifecycle/lint/RepeatOnLifecycleDetector.kt
M lifecycle/lifecycle-runtime-lint/src/main/resources/META-INF/services/com.android.tools.lint.client.api.IssueRegistry
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/ApiLintVersionsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/LifecycleWhenChecksTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/RepeatOnLifecycleDetectorTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/WhenMethodsTest.kt
M lifecycle/lifecycle-runtime-lint/src/test/java/androidx/lifecycle/runtime/lint/stubs/Stubs.kt
M lifecycle/lifecycle-runtime/build.gradle
M settings.gradle

https://android-review.googlesource.com/2957874