Predictive back gesture leads to fragments not being initialized/resumed correctly [297379023]

Fixed

Bug

Status Update

No update yet.

Description

pa...@gmail.com

created issue #1

Aug 24, 2023 06:09PM

Component used: Fragment

Version used: 1.7.0-alpha03

Devices/Android versions reproduced on: Pixel 6 with Android 14

The short summary of the issue is that once the predictive back gesture is completed (or started and canceled only), the fragments seem to be stacked on top of each other, with the top one displaying its contents without being interactive and the bottom one handling the touch input, which leads to crashes and unexpected behavior.

I've attached a minimal sample project to reproduce and describe the issues:

Navigate through the app and its two fragments without using the back gesture: everything works as expected.
On the second fragment, use the back gesture to navigate back to the first fragment. Then tap on the overflow menu: the app crashes unexpectedly with an IndexOutOfBoundsException in FragmentManager.
Relaunch the app and on the second fragment, start the back gesture but cancel it. Then tap on the overflow menu of the second fragment: it doesn't react anymore. Move slightly left with the finger and tap again to open the menu: this time it opens and the toast says "First fragment", which means the touch input is handled by the first fragment and contents are displayed by the second one. Now pause the app by moving it to the background, then resume it: the contents are fully gone and the overflow menu of the first fragment can still be opened by tapping on the top right corner (but slightly left of it because the overflow menu of the second fragment seems to cover the first). Using the back gesture will bring you back to the first fragment, which is then again acting as described in step 2.
Repeat step 3 without pausing the app, then tap on the disabled(!) "Go to second fragment" button of the second fragment: the app crashes with an IllegalArgumentException because the touch input is again handled by the first fragment and it's (enabled!) top button, so the executed navigation transaction (first to second fragment with the second currently displayed) is obviously illegal.

Hope you guys can fix that for the next alpha, thanks for your amazing work! :)

test-predictive.zip

115 KB

Download

Comments

il...@google.com <il...@google.com> Aug 24, 2023 06:28PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Aug 31, 2023 02:04AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

jb...@google.com <jb...@google.com> #3Sep 5, 2023 03:02PM

Marked as fixed.

This is fixed internally and will be available in the Fragment 1.7.0-alpha04 release.

pr...@google.com <pr...@google.com> #4Sep 6, 2023 07:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.7.0-alpha04

pa...@gmail.com <pa...@gmail.com> #5Sep 7, 2023 04:16PM

Thanks Mr Woods! The back gesture now seems to be working, although there are still some remaining issues in alpha04:
When you go to the second fragment in the sample app (with version changed to alpha04 in libs.versions.toml), then the touch targets in the app bar are still covered by some earlier state I think. They are not responding (no ripple and nothing happens), and as soon as you are moving the finger slightly to one side, the touch targets seem to be reached. In my own project with alpha04 the behavior is the same, but multiple taps on the invalid touch target produce an IllegalArgumentException like in alpha03, which I somehow couldn't reproduce with the sample app this time:

java.lang.IndexOutOfBoundsException: Index -1 out of bounds for length 0
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266)
at java.util.Objects.checkIndex(Objects.java:359)
at java.util.ArrayList.get(ArrayList.java:434)
at androidx.fragment.app.FragmentManager.prepareBackStackState(FragmentManager.java:2478)
at androidx.fragment.app.FragmentManager$PrepareBackStackTransitionState.generateOps(FragmentManager.java:3726)
at androidx.fragment.app.FragmentManager.generateOpsForPendingActions(FragmentManager.java:2256)
at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1922)
at androidx.fragment.app.FragmentManager.executePendingTransactions(FragmentManager.java:719)
at androidx.fragment.app.FragmentManager.cancelBackStackTransition(FragmentManager.java:989)
at androidx.fragment.app.FragmentManager$1.handleOnBackCancelled(FragmentManager.java:523)
at androidx.activity.OnBackPressedDispatcher.onBackCancelled(OnBackPressedDispatcher.kt:295)
at androidx.activity.OnBackPressedDispatcher.access$onBackCancelled(OnBackPressedDispatcher.kt:63)
at androidx.activity.OnBackPressedDispatcher$4.invoke(OnBackPressedDispatcher.kt:131)
at androidx.activity.OnBackPressedDispatcher$4.invoke(OnBackPressedDispatcher.kt:127)
at androidx.activity.OnBackPressedDispatcher$Api34Impl$createOnBackAnimationCallback$1.onBackCancelled(OnBackPressedDispatcher.kt:396)
at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.lambda$onBackCancelled$3(WindowOnBackInvokedDispatcher.java:353)
at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper.$r8$lambda$MvEvoNsuMagpR44wZwrfwOccMBA(Unknown Source:0)
at android.window.WindowOnBackInvokedDispatcher$OnBackInvokedCallbackWrapper$$ExternalSyntheticLambda3.run(Unknown Source:2)
at android.window.BackProgressAnimator$2.onAnimationEnd(BackProgressAnimator.java:144)
at com.android.internal.dynamicanimation.animation.DynamicAnimation.endAnimationInternal(DynamicAnimation.java:720)
at com.android.internal.dynamicanimation.animation.DynamicAnimation.doAnimationFrame(DynamicAnimation.java:690)
at android.animation.AnimationHandler.doAnimationFrame(AnimationHandler.java:328)
at android.animation.AnimationHandler.-$$Nest$mdoAnimationFrame(Unknown Source:0)
at android.animation.AnimationHandler$1.doFrame(AnimationHandler.java:86)

Hope you get this fixed and thank you again!

an...@gmail.com <an...@gmail.com> #6Jun 20, 2024 08:49PM

Hi, I am still seeing this crash in our error logs while using version `androidx.fragment:fragment:1.7.0`, but we can't seem to reproduce the crash. Is this still an open issue?

ho...@myrealtrip.com <ho...@myrealtrip.com> #7Oct 15, 2024 03:10AM

Comment has been deleted.

Message last modified on Oct 15, 2024 03:11AM

ha...@gmail.com <ha...@gmail.com> #8Oct 15, 2024 03:12AM

https://issuetracker.google.com/issues/342316801?pli=1

According to above thread, you should either disable predictive back or upgrade the fragment version to 1.8.3