Test failures caused by onAllNodesWithTag returning incorrect number of nodes [297380326]

WAI

Bug

Status Update

No update yet.

Description

da...@ifttt.com

created issue #1

Aug 24, 2023 06:00PM

Jetpack Compose version: 2023.08.00 Jetpack Compose component used: LazyVerticalGrid Android Studio Build: Android Studio Giraffe | 2022.3.1 Patch 1 Kotlin version: 1.9.0

Steps to Reproduce or Code Sample to Reproduce:

Unzip attached sample project
Run the ExampleInstrumentedTest.failingTest test. Observe it fail. This succeeded on prior versions of Compose
Put breakpoints on lines 47 and 53 and try and debug the test.
Observe 4 items in the grid at the first breakpoint, and 1 at the second breakpoint.

The assertion on line 55 fails on compose 2023.08.00 but not the previous version we were on (2023.06.01). Only one item is visible and I would expect that onAllNodesWithTag would return 1 item.

I posted this initially in the kotlin slack here and Andrei from Google asked me to file an issue here.

ComposeUiTestIssue.zip

825 KB

Download

Comments

as...@google.com <as...@google.com> #2Aug 24, 2023 06:28PM

Status: Won't Fix (Intended Behavior)

Hey, thanks for reporting it here.

This is intended behavior, as the nodes you see are being kept for potential reuse in case more items appear. In Lazy layouts, you only want to count placed nodes (as it might prefetch/recycle some, but not place them):

 rule
            .onAllNodesWithTag("ServiceCard")
            .filter(SemanticsMatcher("isPlaced") { it.layoutInfo.isPlaced })
            .assertCountEquals(4)

We are considering filtering placed nodes automatically (or adding additional APIs for this later).

da...@ifttt.com <da...@ifttt.com> #3Aug 24, 2023 06:31PM

Got it. Thanks!

Issue 297380326

Description

Issue summary

Comments

as...@google.com <as...@google.com> #2Aug 24, 2023 06:28PM

da...@ifttt.com <da...@ifttt.com> #3Aug 24, 2023 06:31PM

Add comment

Issue metadata