Status Update
No update yet.
Comments
mi...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt - M
compose/foundation/foundation/api/restricted_current.txt - M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt - M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt - M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
ha...@google.com
mi...@gmail.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06androidx.compose.foundation:foundation-android:1.8.0-alpha06androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
kl...@google.com
I cannot reproduce this on the 1.6 alpha branch. I suspect it was fixed when migrated to the Modifier.Node API. If you can reproduce on the latest 1.6 alpha, please submit a reproducer project and I'll take another look.
mi...@gmail.com
The bug is still there. Reproduced on 1.6.0-alpha06. The bug is also reproduced on the emulator, which means it is not a device-specific bug. I have attached a project with a reproducible bug.
In the demo project I change the velocity of basicMarquee in an infinite loop. It is expected that after each velocity change the animation will start over again, but it "stuck" every second time (when the current scroll animation is active - this is a key part of reproducing the bug).
Minor clarification: source code for basicMarquee modifier is located at androidx.compose.foundation which according to my tests is part of androidx.compose.ui:ui-graphics. At least if I go to implementation in Android Studio it opens the source code of the file C:\Users\Mikhail\.gradle\caches\modules-2\files-2.1\androidx.compose.foundation\foundation-android\1.6.0-alpha06\fe06e22c416549d90173acb7828b3a13f781e8b2\foundation-android-1.6. 0-alpha06-sources.jar!\commonMain\androidx\compose\foundation\BasicMarquee.kt. The version in the path clearly indicates that I am testing the alpha branch. I'll clarify just in case.
kl...@google.com
I'm pretty sure this is a race condition introduced when I converted basicMarquee to a Modifier.Node.
ap...@google.com
Branch: androidx-main
commit cd77952e2a6847a3cea00125c0a7a8214418069c
Author: Zach Klippenstein <klippenstein@google.com>
Date: Mon Sep 25 11:34:38 2023
Fix basicMarquee not animating after velocity change.
Fixes:
Test: BasicMarqueeTest
Relnote: "Fixed `basicMarquee` not animating after velocity change."
Change-Id: Id2e77b47a3fd5cc046e59594cc1d5f01c99f34a0
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/BasicMarqueeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/BasicMarquee.kt
Description
Jetpack Compose version: BOM 2023.08.00 (Compose 1.5.0, I suppose)
Jetpack Compose component(s) used:
androidx.compose.ui:uiandroidx.compose.material3:material3Android Studio Build:
#AI-223.8836.35.2231.10671973, built on August 17, 2023Kotlin version:
223-1.9.0-release-358-AS8836.35.2231.10671973Steps to Reproduce or Code Sample to Reproduce:
basicMarqueewhich starts immediately with customvelocitywhich changes depending fromSlidercomponent.Slider. SometimesbasicMarqueestop working. The content is displayed but not scrolling. If I repeat - sometimes everything returns to normal, sometimes not.velocityfieldbasicMarqueesometimes does not work.Full code, just in case:
Visual demonstration:https://i.imgur.com/zeaIKfN.mp4