Mark all modifier factories as @Stable that meet the requirements. [298046462]

Assigned

Internal Cleanup

Status Update

No update yet.

Description

le...@google.com

created issue #1

Aug 29, 2023 05:46PM

Mark all modifier factories as @Stable that meet the requirements.

If the result of the factory function will compare equals with the result of a second invocation with the exact same parameters, then the function can be marked as @Stable. All of our modifier factories should meet this requirement (however there are some that don't still).

Marking them this way can reduce composition overhead in many common cases and is an easy win.

More context on this issue can be found in aosp/2729638

Comments

ma...@google.com <ma...@google.com> Aug 31, 2023 01:24PM

Reassigned to ma...@google.com.

ap...@google.com <ap...@google.com> #2Sep 8, 2023 05:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

ma...@google.com <ma...@google.com> #3Sep 8, 2023 06:44PM

Reassigned to ra...@google.com.

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

Issue 298046462

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Aug 31, 2023 01:24PM

ap...@google.com <ap...@google.com> #2Sep 8, 2023 05:53PM

ma...@google.com <ma...@google.com> #3Sep 8, 2023 06:44PM

Add comment

Issue metadata