[Regression] Unable to get a @Composable from a GlanceAppWidget (this breaks glance-experimental-tools) [298066147]

Fixed

Bug

Status Update

No update yet.

Description

le...@gmail.com

created issue #1

Aug 30, 2023 01:17PM

Component used: androidx.glance:glance-appwidget
Version used: 1.0.0-rc01
Devices/Android versions reproduced on: Emulator (any API level)

I'm trying to update the glance-experimental-tools project to the latest version of Glance and Compose but, after the release of Glance 1.0.0-beta01, the @Composable Content was removed, in favor of the non Composable function provideCotent: https://developer.android.com/jetpack/androidx/releases/glance#1.0.0-beta01

This change unfortunately breaks the glance-experimental-tools completely, since now it is not possible anymore to generare a snapshot of the Widget.

Comments

za...@google.com <za...@google.com> #2Sep 1, 2023 09:02PM

Reassigned to wv...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit b6f920cbc24f2e12ba3f881a2d61f7e845e9797e
Author: Ian Lake <ilake@google.com>
Date: Fri Nov 19 14:48:01 2021

Avoid saving an empty Bundle for SavedStateRegistry

When performSave() is called, SavedStateRegistry
might actually not have anything to save. In those
cases, it should avoid adding an empty Bundle to
the outBundle.

This allows systems that use SavedStateRegistry
(such as Fragments) to use Bundle.isEmpty() as a
sign on whether it needs to add its Bundle, etc.

Test: new SavedStateRegistryTest test
BUG: 203457956
Change-Id: Ib49bd8645a5d4e38de329e50fe659b1baf7fcba3

M savedstate/savedstate/src/main/java/androidx/savedstate/SavedStateRegistry.java
M savedstate/savedstate/src/androidTest/java/androidx/savedstate/SavedStateRegistryTest.kt

https://android-review.googlesource.com/1896865

wv...@google.com <wv...@google.com> Oct 11, 2023 01:35AM

Accepted by wv...@google.com.

ap...@google.com <ap...@google.com> #3Oct 26, 2023 05:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5729d1dadf2abd51e1b092a891becea6f138e553
Author: Willie Koomson <wvk@google.com>
Date: Thu Sep 28 13:07:19 2023

Add GlanceAppWidget.runComposition

This change adds GlanceAppWidget.runComposition which returns a
Flow<RemoteViews>. This API can be used to run the widget outside of the
app widget system (e.g. without a GlanceAppWidgetReceiver or needing to
be bound by the AppWidgetHost) and without a Worker. The widget will
continue to recompose and respond to lambda actions while the flow is
running.

This makes it straightforward to display a widget within an Activity,
and is intended to be used for the glance-experimental-tools
WidgetViewer, which provides Live Edit in Studio.

Bug: 298066147
Test: SimpleWidgetViewer demo activity, GlanceAppWidgetTest unit tests
Relnote: "Add GlanceAppWidget.runComposition"
Change-Id: I6344ce93a486a86b7484dfd704453da118e3aa79

M glance/glance-appwidget/api/current.txt
M glance/glance-appwidget/api/restricted_current.txt
M glance/glance-appwidget/integration-tests/demos/build.gradle
M glance/glance-appwidget/integration-tests/demos/src/main/AndroidManifest.xml
A glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/SimpleWidgetViewer.kt
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/strings.xml
M glance/glance-appwidget/src/main/AndroidManifest.xml
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/AppWidgetComposer.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/AppWidgetSession.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/AppWidgetUtils.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceAppWidget.kt
M glance/glance-appwidget/src/main/java/androidx/glance/appwidget/GlanceRemoteViewsService.kt
A glance/glance-appwidget/src/main/java/androidx/glance/appwidget/UnmanagedSessionReceiver.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/AppWidgetSessionTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/GlanceAppWidgetTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/TestUtils.kt
M glance/glance/src/main/java/androidx/glance/session/SessionWorker.kt
M glance/glance/src/main/java/androidx/glance/session/TimerScope.kt

https://android-review.googlesource.com/2769659

ro...@veeva.com <ro...@veeva.com> #4Nov 23, 2023 12:17PM

Hi is there an ETA for the next release containing this patch?

za...@google.com <za...@google.com> #5Mar 29, 2024 11:16PM

Marked as fixed.

The fix is included in the next beta release (April 2024), which will be fast followed by stable.

Issue 298066147