Edge-to-edge does not draw behind 3-button nav on modern API levels [298296168]

Fixed

Bug

Status Update

No update yet.

Description

go...@jakewharton.com

created issue #1

Aug 31, 2023 02:32AM

Component used: Activity

Version used: 1.8.0-alpha07

Devices/Android versions reproduced on: API 34 emulator, API 33 device

The new edgeToEdge API does not specify enough Window flags to properly go edge-to-edge on modern API levels when 3-button nav (and presumably 2-button nav) is used.

Attached are screenshots of an app whose activity is configured as such:

class UiActivity : ComponentActivity() {
  override fun onCreate(savedInstanceState: Bundle?) {
    super.onCreate(savedInstanceState)

    enableEdgeToEdge(
      statusBarStyle = SystemBarStyle.auto(TRANSPARENT, TRANSPARENT) {
        // App bar is inverted, so dark icons in dark mode and light icons in light mode.
        resources.configuration.uiMode and UI_MODE_NIGHT_MASK) == UI_MODE_NIGHT_NO
      },
    )

When in gesture mode, the Compose UI bottom nav within a scaffold draws behind the gesture bar. However, when switching the OS to 3-button navigation, the activity no longer draws behind the navigation bar.

My workaround, for now, is to add the following window flag:

window.setFlags(FLAG_LAYOUT_NO_LIMITS, FLAG_LAYOUT_NO_LIMITS);

I believe the library should do this automatically to accommodate 2- and 3-button nav on modern API levels.

gesture.png

21 KB

View

Download

three.png

22 KB

View

Download

three-fixed.png

22 KB

View

Download

Comments

ya...@google.com <ya...@google.com> #2Aug 31, 2023 04:14AM

After some googling I found

https://github.com/android/camera-samples/blob/master/CameraXBasic/app/src/main/java/com/android/example/cameraxbasic/utils/AutoFitPreviewBuilder.kt which does what I want. Would it be possible to fold this into the main library or at least make it configurable without the need for that class?

go...@jakewharton.com <go...@jakewharton.com> #3Aug 31, 2023 04:35AM

Hi Charcoal,

Are we getting a crop mode here? Thanks!

ya...@google.com <ya...@google.com> #4Aug 31, 2023 06:04AM

Hello,
Thanks for raising this up. May we know did you set aspect ratio or resolution for Preview use case? And could you also attach the captured image file?

go...@jakewharton.com <go...@jakewharton.com> #5Aug 31, 2023 02:06PM

The captured image file is part of the image file that I've already attached (the right part).

I did not set anything on the Preview use case other than the lens facing.

```
val cameraPreview = Preview(Builder()
.setLensFacing(CameraX.LensFacing.BACK)
.build())

cameraPreview.setOnPreviewOutputUpdateListener {
// Every time the viewfinder is updated, recompute the layout. By removing and re-adding it.
val parent = parent as ViewGroup
parent.removeView(this)
parent.addView(this, 0)

surfaceTexture = it.surfaceTexture
updateTransform()
}

CameraX.bindToLifecycle(lifecycleOwner, cameraPreview, *useCase)
```

va...@google.com <va...@google.com> #6Aug 31, 2023 06:12PM

Would you also set the same TargetRotation to Preview at onOrientationChanged? Let me know if it works.

ya...@google.com <ya...@google.com> #7Sep 1, 2023 01:21AM

Hi There,

It's been just over a month and we are clearing out issues without response. If you have any feedback please feel free to reopen or file another issue. Thanks!

il...@google.com <il...@google.com> Sep 5, 2023 04:23PM

Assigned to ya...@google.com.

ap...@google.com <ap...@google.com> #8Oct 13, 2023 08:18PM

This should be caused by same root cause of

https://b.corp.google.com/issues/148763432.
There is default aspect ratio custom set to ImageCapture use case but it is not updated to match the new target rotation value.

ya...@google.com <ya...@google.com> Oct 16, 2023 05:24AM

Marked as fixed.

pr...@google.com <pr...@google.com> #9Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.activity:activity:1.9.0-alpha01

ma...@gmail.com <ma...@gmail.com> #10Feb 27, 2024 12:59AM

https://issuetracker.google.com/issues/326356902:

Isn't EnableEdgeToEdge() easier to use if it doesn't override enforceNavigationBarContrast?

lc...@gmail.com <lc...@gmail.com> #11Mar 12, 2024 02:35AM

The documentation on SystemBarStyle.light and SystemBarStyle.dark is a bit lacking imo.

For the arguments for colors for scrim and darkScrim in SystemBarStyle.light, when will scrim and darkScrim be applied? Is it when then app is in dark or light mode?

I think the confusion comes from the naming of the style. SystembarStyle.light sounds like this is a style used when the app is in light mode, and SystemBarStyle.dark in dark mode. And why does SystemBarStyle.dark not let devs specify scrim and darkScrim as with SystemBarStyle.light?

And some description on how the light systembar icons are enforced would be good. I assume that when darkScrim is used the systembar icons are automatically set to light due to enforced systembar Contrast?

ya...@google.com <ya...@google.com> #12Mar 13, 2024 06:56AM

We updated the javadoc based on some feedback. https://developer.android.com/reference/kotlin/androidx/activity/SystemBarStyle?hl=en#dark(kotlin.Int) I believe it explains all the points in #comment11, but I'm open to suggestions.

ma...@gmail.com <ma...@gmail.com> #13Apr 9, 2024 01:04AM

Ubahh semua INI CUMAN BISA LIAT ADI SAMA ISTRINYA YG PERNA PIU PIU SAMA MANTAN SEBELUMNYA.

Issue 298296168

Description

Issue summary

Comments

ya...@google.com <ya...@google.com> #2Aug 31, 2023 04:14AM

go...@jakewharton.com <go...@jakewharton.com> #3Aug 31, 2023 04:35AM

ya...@google.com <ya...@google.com> #4Aug 31, 2023 06:04AM

go...@jakewharton.com <go...@jakewharton.com> #5Aug 31, 2023 02:06PM

va...@google.com <va...@google.com> #6Aug 31, 2023 06:12PM

ya...@google.com <ya...@google.com> #7Sep 1, 2023 01:21AM

il...@google.com <il...@google.com> Sep 5, 2023 04:23PM

ap...@google.com <ap...@google.com> #8Oct 13, 2023 08:18PM

ya...@google.com <ya...@google.com> Oct 16, 2023 05:24AM

pr...@google.com <pr...@google.com> #9Nov 29, 2023 09:39PM

ma...@gmail.com <ma...@gmail.com> #10Feb 27, 2024 12:59AM

lc...@gmail.com <lc...@gmail.com> #11Mar 12, 2024 02:35AM

ya...@google.com <ya...@google.com> #12Mar 13, 2024 06:56AM

ma...@gmail.com <ma...@gmail.com> #13Apr 9, 2024 01:04AM

Add comment

Issue metadata