Reconsider whether MagnifierStyle.TextDefault is required [298381260]

Obsolete

Bug

Status Update

No update yet.

Description

ha...@google.com

created issue #1

Aug 31, 2023 01:35PM

TextDefault is almost the same as Default value of MagnifierStyle. However, there is a specific branching condition in PlatformMagnifierFactory that references text defaults. Check on API 28 and 29 whether this if condition is doing anything different when taken or not.

Comments

ap...@google.com <ap...@google.com> #2Sep 4, 2023 11:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

ha...@google.com <ha...@google.com> Sep 4, 2023 12:02PM

Status: Won't Fix (Obsolete)

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

Issue 298381260

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Sep 4, 2023 11:53AM

ha...@google.com <ha...@google.com> Sep 4, 2023 12:02PM

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

Add comment

Issue metadata