Fixed
Status Update
Comments
th...@gmail.com <th...@gmail.com> #2
Lines for reference in ModalBottomSheet.android.kt
causing this behavior:
val newTarget = when (sheetState.anchoredDraggableState.targetValue) {
Hidden -> Hidden
PartiallyExpanded, Expanded -> {
val hasPartiallyExpandedState = newAnchors
.hasAnchorFor(PartiallyExpanded)
val newTarget = if (hasPartiallyExpandedState) PartiallyExpanded
else if (newAnchors.hasAnchorFor(Expanded)) Expanded else Hidden
newTarget
}
}
ap...@google.com <ap...@google.com> #3
My proposed solution would be:
val targetValue = sheetState.anchoredDraggableState.targetValue
val newTarget = when (targetValue) {
Hidden -> Hidden
PartiallyExpanded, Expanded -> {
when {
newAnchors.hasAnchorFor(targetValue)) -> targetValue
newAnchors.hasAnchorFor(PartiallyExpanded)) -> PartiallyExpanded
newAnchors.hasAnchorFor(Expanded)) -> Expanded
else -> Hidden
}
}
}
lo...@gmail.com <lo...@gmail.com> #4
Project: chromium/src
Branch: main
commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024
[ASH] Add fieldtrial_testing_config
Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5516358
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}
M testing/variations/fieldtrial_testing_config.json
https://chromium-review.googlesource.com/5516358
Branch: main
commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024
[ASH] Add fieldtrial_testing_config
Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}
M testing/variations/fieldtrial_testing_config.json
ke...@google.com <ke...@google.com>
ke...@google.com <ke...@google.com>
na...@google.com <na...@google.com> #5
any update on this? 😅
Description
Jetpack Compose version: androidx.compose.material3:material3-android:1.2.0-alpha06 Jetpack Compose component used: ModalBottomSheet Android Studio Build: Build #AI-223.8836.35.2231.10671973, built on August 17, 2023 Kotlin version: 1.8.12 Devices/Android versions reproduced on: Pixel 6, AndroidStudio preview
ModalBottomSheet adds extra offset at the right of the screen visible on the screenshots. This is even more visible if you adjust preview width.