ConstraintLayout hides Views when one view has Visibility = GONE and width = Dimension.fillToConstraints [299134793]

Fixed

Bug

Status Update

No update yet.

Description

ja...@veeva.com

created issue #1

Sep 6, 2023 11:16AM

ConstraintLayout version: constraintlayout-compose:1.1.0-alpha12
Jetpack Compose version: 1.6.0-alpha04
Jetpack Compose component used: ConstraintLayout
Android Studio Build: Android Studio Giraffe | 2022.3.1 Build #AI-223.8836.35.2231.10406996, built on June 29, 2023 Runtime version: 17.0.6+0-17.0.6b829.9-10027231 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Kotlin version: 1.9.10
Material Version: material3:1.2.0-alpha06

This is a regression issue, latest version of constraintlayout-compose which worked well: 1.1.0-alpha05

Steps to Reproduce or Code Sample to Reproduce:

Create a ConstraintLayout with 2 ComposeViews inside
Show one ComposeView or another depending on a flag
Change visibility of these views depending on this flag (visibility = if (!detailVisible) Visibility.Gone else Visibility.Visible)
The ComposeView not visible the first time with the width = Dimension.fillToConstraints property causes the other ComposeView not to be shown on the screen

Sample Code

@Composable
fun MainContent() {
    var detailVisible by rememberSaveable { mutableStateOf(false) }
    ConstraintLayout(
        modifier = Modifier
            .padding(16.dp)
            .fillMaxSize()
            .clickable { detailVisible = !detailVisible },
    ) {
        val (titleRef, detailRef) = createRefs()
        Text(
            text = "Text 1 - Detail",
            modifier = Modifier.constrainAs(detailRef) {
                start.linkTo(parent.start)
                width = Dimension.fillToConstraints
                visibility = if (!detailVisible) Visibility.Gone else Visibility.Visible
            },
        )
        Text(
            text = "Text 2",
            modifier = Modifier
                .constrainAs(titleRef) {
                    width = Dimension.fillToConstraints
                    visibility = if (detailVisible) Visibility.Gone else Visibility.Visible
                },
        )
    }
}

Here you can find a sample project to reproduce it: https://github.com/jarroyoesp/ConstraintLayoutIssue

And this issue just happens in case we use Visibility.Gone. If we use Visibility.Invisible it works well.

Temporary Fix

We find a possible fix. If we only set width to Dimension.fillToConstraints and in other case we set to Dimension.wrapContent, all the ComposeViews are shown when is their time.

Text(
    text = ...,
    modifier = Modifier.constrainAs(detailRef) {
        ....
        width = if (!detailVisible) Dimension.wrapContent else Dimension.fillToConstraints
        visibility = if (!detailVisible) Visibility.Gone else Visibility.Visible
    },
)

Comments

le...@gmail.com <le...@gmail.com> #2Nov 21, 2023 02:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ja...@veeva.com <ja...@veeva.com> #3Nov 21, 2023 02:13PM

Hey, after upgrading some dependencies our team is still facing the issue, any advance on this?

androidx-compose = "1.6.0-beta01"
material3 = "1.2.0-alpha11"
constraintlayout-compose = "1.1.0-alpha13"

Thanks!

ho...@google.com <ho...@google.com> Oct 30, 2024 03:48PM

Reassigned to os...@google.com.

ko...@gmail.com <ko...@gmail.com> #4Nov 8, 2024 11:01PM

This issues is shipped into 1.1.0 stable version. It is a breaking behaviour change and a bug.

os...@google.com <os...@google.com> Nov 8, 2024 11:43PM

Accepted by os...@google.com.

cl...@google.com <cl...@google.com> #5Dec 9, 2024 05:53PM

Lowering the priority to get it off the chaselist

ap...@google.com <ap...@google.com> #6Jan 9, 2025 11:42PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Oscar Adame Vázquez <oscarad@google.com>
Link: https://android-review.googlesource.com/3349446

Fix Measure/Layout pass handling in ConstraintLayout

Expand for full commit details

Fix Measure/Layout pass handling in ConstraintLayout 
 
ConstraintLayout was not properly handling Measurable/Placeable lifecycle. 
 
As different passes are made with different instances, improper upkeep can result in issues, such as Composables not being placed. 
 
Relnote: N/A 
 
Fixes: 299134793 
Test: updated with regression test case 
Change-Id: I3831c682b409105274f4bf2e98af303395561c35

Files:

D constraintlayout/constraintlayout-compose/api/current.ignore
D constraintlayout/constraintlayout-compose/api/restricted_current.ignore
M constraintlayout/constraintlayout-compose/api/restricted_current.txt
M constraintlayout/constraintlayout-compose/src/androidInstrumentedTest/kotlin/androidx/constraintlayout/compose/ConstraintLayoutTest.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstraintLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/LateMotionLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionMeasurer.kt

Hash: c999aaf73e2eba0b893c3fde2546c6d400f77431
Date: Tue Nov 12 13:37:12 2024

jr...@gmail.com <jr...@gmail.com> #7Jan 10, 2025 10:10AM

Thanks for fixing!. This was preventing us to update the libraries without adding quite a few workarounds. Will this be released as a new stable version soon?

ap...@google.com <ap...@google.com> #8Jan 31, 2025 11:43PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Oscar Adame Vázquez <oscarad@google.com>
Link: https://android-review.googlesource.com/3461062

Re-land fix for Measure/Layout pass in ConstraintLayout

Expand for full commit details

Re-land fix for Measure/Layout pass in ConstraintLayout 
 
Similar as I3831c682b409105274f4bf2e98af303395561c35 but without changes to PublishedApi. 
 
ConstraintLayout was not properly handling Measurable/Placeable lifecycle. 
 
As different passes are made with different instances, improper upkeep can result in issues, such as Composables not being placed. 
 
Bug: 299134793 
Test: updated with regression test case 
Change-Id: Ia3351e13e1ee96bc33f5e6bb5e4f522274ff9c5f

Files:

M constraintlayout/constraintlayout-compose/api/restricted_current.txt
M constraintlayout/constraintlayout-compose/src/androidInstrumentedTest/kotlin/androidx/constraintlayout/compose/ConstraintLayoutTest.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/ConstraintLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/LateMotionLayout.kt
A constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/Measurer.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionLayout.kt
M constraintlayout/constraintlayout-compose/src/androidMain/kotlin/androidx/constraintlayout/compose/MotionMeasurer.kt

Hash: 796a51fffa3202f9d206e49a62d6255d645364cb
Date: Tue Jan 21 14:22:31 2025

os...@google.com <os...@google.com> #9Feb 26, 2025 07:22PM

The fix should now be available in :constraintlayout-compose:1.1.1

Message last modified on Feb 26, 2025 07:22PM