popUpTo on route with arguments does not work [299255572]

Fixed

Bug

Status Update

No update yet.

Description

re...@lunabee.com

created issue #1

Sep 6, 2023 03:36PM

Component used: Navigation Version used: 2.7.0 Devices/Android versions reproduced on: Pixel 3XL API 31

navigate with popUpTo does not work with arguments (-> Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack). It seems to be due to the destination id equality test, the id is generated with the route with placeholder, and tested against the resolved route. Using popBackStack + navigate gives the expected result

https://github.com/rlatapy-luna/Compose-Playground/blob/navigation/popupto/app/src/main/java/rlatapy/composeplayground/MainActivity.kt

System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Nav to A (foo)
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [STARTED] [-469060434]
System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Nav to A + popupto (foo)
NavController  I  Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popupto_foo [STARTED] [-469060434]
System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popupto_foo [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Popback A(foo) + Navigate
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popback_and_navigate_foo [STARTED]

Comments

jb...@google.com <jb...@google.com> #2Sep 6, 2023 04:05PM

Status: Won't Fix (Intended Behavior)

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

re...@gmail.com <re...@gmail.com> #3Sep 6, 2023 04:10PM

Yes, but I have the destination with the same args in the backstack so I expect popupto to pop until this entry, no ?
It's seems that we are only able to pop to an entry without args.

re...@lunabee.com <re...@lunabee.com> #4Sep 7, 2023 11:33PM

Should I rephrase the problem and add a unit test?

jb...@google.com <jb...@google.com> Sep 26, 2023 04:53PM

Status: Assigned (reopened)

jb...@google.com <jb...@google.com> Sep 26, 2023 05:54PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #5Sep 27, 2023 09:52PM

Project: platform/frameworks/support
Branch: androidx-main

commit d29b0c29df8663842de9f6caa03eb8dea74e8116
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 27 14:00:16 2023

Add support for navigating with popUpTo route

Test: ./gradlew navigation:navigation-runtime:cC
Bug: 299255572
Relnote: "Added support for popUpTo routes with arguments while navigating."
Change-Id: I731f4cf31dff5832e1203265c0420ac7baa10d49

M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt

https://android-review.googlesource.com/2766106

cl...@google.com <cl...@google.com> #6Sep 27, 2023 10:01PM

Marked as fixed.

Fixed internally and will be available in navigation 2.7.4

na...@google.com <na...@google.com> #7Jan 24, 2024 07:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-runtime:2.8.0-alpha01