Fixed
Status Update
Comments
jb...@google.com <jb...@google.com> #2
That is correct. Destinations with different arguments are indeed considered different destinations. You will need to pop the previous destination off the back stack to have the desired result.
re...@gmail.com <re...@gmail.com> #3
Yes, but I have the destination with the same args in the backstack so I expect popupto to pop until this entry, no ?
It's seems that we are only able to pop to an entry without args.
It's seems that we are only able to pop to an entry without args.
re...@lunabee.com <re...@lunabee.com> #4
Should I rephrase the problem and add a unit test?
jb...@google.com <jb...@google.com>
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit d29b0c29df8663842de9f6caa03eb8dea74e8116
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 27 14:00:16 2023
Add support for navigating with popUpTo route
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 299255572
Relnote: "Added support for popUpTo routes with arguments while navigating."
Change-Id: I731f4cf31dff5832e1203265c0420ac7baa10d49
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/2766106
Branch: androidx-main
commit d29b0c29df8663842de9f6caa03eb8dea74e8116
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 27 14:00:16 2023
Add support for navigating with popUpTo route
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 299255572
Relnote: "Added support for popUpTo routes with arguments while navigating."
Change-Id: I731f4cf31dff5832e1203265c0420ac7baa10d49
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
cl...@google.com <cl...@google.com> #6
Fixed internally and will be available in navigation 2.7.4
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-runtime:2.8.0-alpha01
Description
Component used: Navigation Version used: 2.7.0 Devices/Android versions reproduced on: Pixel 3XL API 31
navigate
withpopUpTo
does not work with arguments (->Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack
). It seems to be due to the destination id equality test, the id is generated with the route with placeholder, and tested against the resolved route. UsingpopBackStack
+navigate
gives the expected result