Fixed
Status Update
Comments
jb...@google.com <jb...@google.com> #2
It turns out this issue is due to by navArgs()
moving to navigation-common
, but the ProGuard rules still being located in the (now empty) navigation-common-ktx
. This means you can work around this issue by explicitly adding a dependency on androidx.navigation:navigation-common-ktx:2.4.0-alpha02
.
re...@gmail.com <re...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 55af5f168e5a1e6dc73c8d35ac79598cb4ae5bd8
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 09 16:57:14 2021
Move ProGuard rules from navigation-common-ktx to common
NavArgsLazy was moved to navigation-common, but
the related proguard-rules.pro wasn't moved with it.
This meant that apps that didn't specifically include
the (now empty) navigation-common-ktx artifact wouldn't
get the correct set of ProGuard rules.
Test: tested in sample app
BUG: 190082521
Relnote: "ProGuard rules for `by navArgs()` now properly
apply when using `navigation-common` or any artifacts
that depend on it."
Change-Id: I688009632403c98afe728d856ce91cd056ef32a5
M navigation/navigation-common-ktx/build.gradle
M navigation/navigation-common/build.gradle
M navigation/navigation-common/proguard-rules.pro
https://android-review.googlesource.com/1732586
Branch: androidx-main
commit 55af5f168e5a1e6dc73c8d35ac79598cb4ae5bd8
Author: Ian Lake <ilake@google.com>
Date: Wed Jun 09 16:57:14 2021
Move ProGuard rules from navigation-common-ktx to common
NavArgsLazy was moved to navigation-common, but
the related proguard-rules.pro wasn't moved with it.
This meant that apps that didn't specifically include
the (now empty) navigation-common-ktx artifact wouldn't
get the correct set of ProGuard rules.
Test: tested in sample app
BUG: 190082521
Relnote: "ProGuard rules for `by navArgs()` now properly
apply when using `navigation-common` or any artifacts
that depend on it."
Change-Id: I688009632403c98afe728d856ce91cd056ef32a5
M navigation/navigation-common-ktx/build.gradle
M navigation/navigation-common/build.gradle
M navigation/navigation-common/proguard-rules.pro
re...@lunabee.com <re...@lunabee.com> #4
This has been fixed internally and will be available in Navigation 2.4.0-alpha03.
jb...@google.com <jb...@google.com>
jb...@google.com <jb...@google.com>
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit d29b0c29df8663842de9f6caa03eb8dea74e8116
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 27 14:00:16 2023
Add support for navigating with popUpTo route
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 299255572
Relnote: "Added support for popUpTo routes with arguments while navigating."
Change-Id: I731f4cf31dff5832e1203265c0420ac7baa10d49
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/2766106
Branch: androidx-main
commit d29b0c29df8663842de9f6caa03eb8dea74e8116
Author: Clara Fok <clarafok@google.com>
Date: Wed Sep 27 14:00:16 2023
Add support for navigating with popUpTo route
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 299255572
Relnote: "Added support for popUpTo routes with arguments while navigating."
Change-Id: I731f4cf31dff5832e1203265c0420ac7baa10d49
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerRouteTest.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
cl...@google.com <cl...@google.com> #6
Fixed internally and will be available in navigation 2.7.4
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-runtime:2.8.0-alpha01
Description
Component used: Navigation Version used: 2.7.0 Devices/Android versions reproduced on: Pixel 3XL API 31
navigate
withpopUpTo
does not work with arguments (->Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack
). It seems to be due to the destination id equality test, the id is generated with the route with placeholder, and tested against the resolved route. UsingpopBackStack
+navigate
gives the expected result