popUpTo on route with arguments does not work [299255572]

Fixed

Bug

Status Update

No update yet.

Description

re...@lunabee.com

created issue #1

Sep 6, 2023 03:36PM

Component used: Navigation Version used: 2.7.0 Devices/Android versions reproduced on: Pixel 3XL API 31

navigate with popUpTo does not work with arguments (-> Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack). It seems to be due to the destination id equality test, the id is generated with the route with placeholder, and tested against the resolved route. Using popBackStack + navigate gives the expected result

https://github.com/rlatapy-luna/Compose-Playground/blob/navigation/popupto/app/src/main/java/rlatapy/composeplayground/MainActivity.kt

System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Nav to A (foo)
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [STARTED] [-469060434]
System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Nav to A + popupto (foo)
NavController  I  Ignoring popBackStack to destination -1082070894 as it was not found on the current back stack
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popupto_foo [STARTED] [-469060434]
System.out     I  Nav to B
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/foo [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popupto_foo [CREATED] [-469060434]
System.out     I  	• screen_b [STARTED] [717579228]
System.out     I  Popback A(foo) + Navigate
System.out     I  Main nav
System.out     I  	• null [RESUMED] [0]
System.out     I  	• screen_a/null [CREATED] [-469060434]
System.out     I  	• screen_b [CREATED] [717579228]
System.out     I  	• screen_a/popback_and_navigate_foo [STARTED]

Comments

jb...@google.com <jb...@google.com> #2Sep 6, 2023 04:05PM

Status: Won't Fix (Intended Behavior)

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

re...@gmail.com <re...@gmail.com> #3Sep 6, 2023 04:10PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

re...@lunabee.com <re...@lunabee.com> #4Sep 7, 2023 11:33PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

jb...@google.com <jb...@google.com> Sep 26, 2023 04:53PM

Status: Assigned (reopened)

jb...@google.com <jb...@google.com> Sep 26, 2023 05:54PM

Reassigned to cl...@google.com.

ap...@google.com <ap...@google.com> #5Sep 27, 2023 09:52PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

cl...@google.com <cl...@google.com> #6Sep 27, 2023 10:01PM

Marked as fixed.

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

na...@google.com <na...@google.com> #7Jan 24, 2024 07:52PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!