ParagraphStyle causes lots of boxing [299490814]

Fixed

Internal Cleanup

Status Update

No update yet.

Description

le...@google.com

created issue #1

Sep 7, 2023 06:19PM

TextAlign, TextDirection, LineBreak, Hyphens, and TextMotion are all value classes, but we are causing them to constantly box/unbox here by making them nullable. We should consider making a Foo.Unspecified for each of them if it doesn't exist and figuring out a good way to backwards-compatibly migrate this API. It should be possible because the non-nullable signatures will have primitives instead of objects in the signature and thus will have a different JVM binary signature

Comments

si...@google.com <si...@google.com> Sep 12, 2023 08:28PM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> Sep 22, 2023 03:23PM

Reassigned to so...@google.com.

ap...@google.com <ap...@google.com> #2Oct 5, 2023 03:38PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ap...@google.com <ap...@google.com> #3Oct 9, 2023 06:01PM

BTW - one data point for emoji support in Compose. https://screenshot.googleplex.com/AyPUhXqMcgPDzJQ

so...@google.com <so...@google.com> Oct 10, 2023 10:19PM

Marked as fixed.

pr...@google.com <pr...@google.com> #4Oct 18, 2023 08:42PM

redacted

Issue 299490814