Fixed
Status Update
Comments
le...@google.com <le...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <
Link:
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
Expand for full commit details
Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component.
Fixes: b/266550551
Fixes: b/204650733
Fixes: b/255554340
Fixes: b/229537244
Test: OverscrollTest
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere."
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61
Files:
- M
compose/foundation/foundation/api/current.txt
- M
compose/foundation/foundation/api/restricted_current.txt
- M
compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
- M
compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
- M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt
Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024
di...@googlemail.com <di...@googlemail.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit e8902c95627d25d07d05a66bd808562ece482571
Author: Levi Albuquerque <levima@google.com>
Date: Wed Sep 13 09:51:58 2023
Update SnapPositionInLayout to have more info about the Layout.
Make it more clear that the layout size in the position method is actually with respect to the available space (after subtracting the content paddings). Introduce content padding to the position method.
Test: N/A
Fixes: 300116110
Relnote: Update SnapPositionInLayout documentation and position method. Introduce content paddings to the position method in SnapPositionInLayout.
Change-Id: Id79383a2bc99bc7db54f716fdfd7b0aa6708cfac
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/snapping/SnapPositionInLayout.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
https://android-review.googlesource.com/2750222
Branch: androidx-main
commit e8902c95627d25d07d05a66bd808562ece482571
Author: Levi Albuquerque <levima@google.com>
Date: Wed Sep 13 09:51:58 2023
Update SnapPositionInLayout to have more info about the Layout.
Make it more clear that the layout size in the position method is actually with respect to the available space (after subtracting the content paddings). Introduce content padding to the position method.
Test: N/A
Fixes: 300116110
Relnote: Update SnapPositionInLayout documentation and position method. Introduce content paddings to the position method in SnapPositionInLayout.
Change-Id: Id79383a2bc99bc7db54f716fdfd7b0aa6708cfac
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/snapping/SnapPositionInLayout.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/pager/PagerState.kt
di...@googlemail.com <di...@googlemail.com> #5
I Like it. It solves the issue
Description
Jetpack Compose component(s) used: foundation, material, livedata
Android Studio Build:
Kotlin version: 1.9.10
Steps to Reproduce or Code Sample to Reproduce:
val snappingLayout = remember(state) { SnapLayoutInfoProvider(state, positionInLayout = SnapPositionInLayout.CenterToCenter) }
val flingBehavior = remeberSnapFlingBehavior(snappingLayout)
LazyRow(state = state, flingBehavior = flingBehavior, contentPadding = PaddingValues(start = 100.dp, end = 200.dp))
with item that has 100.dp and 49.dp width
The layoutSize inside of positionInLayout should not subtract contentpadding from mainAxisViewPortSize?
In my usecase, the items are not centered to the container.
If it is not including content padding. It is not clear, what and how to calc the positionInLayout.