LoremIpsum preview parameter customization [300116360]

Fixed

Bug

Status Update

No update yet.

Description

pe...@gmail.com

created issue #1

Sep 13, 2023 08:33AM

Issue

LoremIpsum doesn't seem to offer an option, to specify number of words. Sometimes you want to preview how specific composable behaves, when line breaks a single time. LoremIpsum only offers "a truck load" amount of words.

So basically, I would like to be able to preview text with only 20 words, instead of 500 (that's current default word count set in LoremIpsum).

Example

I want to preview how following text breaks, but I don't want it to expand indefinitely.

Yes, I could limit it by height, but sometimes composables are more complicated than that.

@Preview
@Composable
fun Preview(@PreviewParameter(LoremIpsum::class) text: String) {
    Text(text)
}

Current workarounds

A. Only take first n characters

@Preview
@Composable
fun Preview(@PreviewParameter(LoremIpsum::class) text: String) {
    Text(text.take(100))
}

B. Manually instantiate LoremIpsum

@Preview
@Composable
fun Preview() {
    val text = LoremIpsum(20).values.first()
    Text(text)
}

Potential solutions

Maybe short version of LoremIpsum could solve this use case in a simple way? E.g. LoremIpsumShort?

Info

Jetpack Compose version: 1.5.1
Jetpack Compose component(s) used: androidx.compose.ui:ui-tooling-preview
Android Studio Build: #AI-231.9392.1.2311.10717887

Comments

st...@gmail.com <st...@gmail.com> #2Sep 13, 2023 09:26AM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

mn...@google.com <mn...@google.com> Sep 15, 2023 07:37PM

Assigned to di...@google.com.

di...@google.com <di...@google.com> Sep 18, 2023 09:04AM

Status: New

am...@google.com <am...@google.com> Oct 5, 2023 02:00PM

Accepted by am...@google.com.

am...@google.com <am...@google.com> #3Oct 6, 2023 01:42PM

Marked as fixed.

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

pr...@google.com <pr...@google.com> #4Oct 18, 2023 08:41PM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.