ModalBottomSheet in landscape does not draw edge to edge [300280229]

Verified

Bug

Status Update

No update yet.

Description

jb...@physitrack.com

created issue #1

Sep 14, 2023 09:32AM

Jetpack Compose version: BOM 2023.09.00 Jetpack Compose component used: Material3 Android Studio Build: #AI-223.8836.35.2231.10671973 Kotlin version: 1.9.10

Steps to Reproduce or Code Sample to Reproduce:

Have a sample code like this with edge-to-edge enabled:

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        WindowCompat.setDecorFitsSystemWindows(window, false)

        setContent {
            val view = LocalView.current

            LaunchedEffect(Unit) {
                window?.statusBarColor = Color.Transparent.toArgb()
                window?.navigationBarColor = Color.Transparent.toArgb()
                window?.let { WindowCompat.getInsetsController(it, view) }
                    ?.let {
                        it.isAppearanceLightStatusBars = true
                        it.isAppearanceLightNavigationBars = true
                    }
            }

            MyApplicationTheme {
                ModalBottomSheet(
                    modifier = Modifier.navigationBarsPadding(),
                    windowInsets = WindowInsets(0, 0, 0, 0),
                    onDismissRequest = { },
                ) {
                    Column(modifier = Modifier.height(200.dp)) {

                    }
                }
            }
        }
    }
}

Have system navigation using buttons not gestures
Open the app and rotate the phone to landscape
You would expect the scrim to be displayed edge-to-edge but the modal is cut on the right. Most probably by some incorrectly applied window insets.

Please see attached screenshot

Screenshot_20230914_112338.png

38 KB

View

Download

Comments

se...@google.com <se...@google.com> #2Mar 25, 2024 07:25PM

Reassigned to se...@google.com.

The only currently supported strategy for adding Fragments to compose is via AndroidViewBinding. Are you familiar with this approach?

jb...@physitrack.com <jb...@physitrack.com> #3Mar 26, 2024 07:24AM

Yes, I am familiar with AndroidViewBinding, however, as far as I know it has some limitations, like, I can't decide at runtime what fragment to commit.

ap...@google.com <ap...@google.com> #4Apr 22, 2024 12:07PM

I also can't give parameters to the fragment being inflated.

se...@google.com <se...@google.com> Jul 29, 2024 07:44PM

Verified by se...@google.com.

ar...@physitrack.com <ar...@physitrack.com> #5Sep 6, 2024 09:55AM

Project: platform/frameworks/support
Branch: androidx-main

commit ffe9335a155bf0dea9c3558e50da01d526579040
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 26 20:24:54 2024

Create AndroidFragment to allow adding fragments in Compose

Adding new AndroidFragment API that creates the given Fragment class and
adds it to the enclosing FragmentManager, within Compose.

It handles setting the ViewCompositionStrategy and saving the state of
the fragment across recompositions.

RelNote: "The new AndroidFragment Composable allows adding fragments
into the Compose hierarchy via the fragment class name."
Test: added AndroidFragmentTest
Bug: 230126482
Bug: 312895363

Change-Id: Icf84199bbe487b2a2b6a95d2b6e09415f810e77a

M docs-tip-of-tree/build.gradle
M fragment/fragment-compose/api/current.txt
M fragment/fragment-compose/api/restricted_current.txt
M fragment/fragment-compose/build.gradle
A fragment/fragment-compose/samples/build.gradle
A fragment/fragment-compose/samples/src/main/java/androidx/fragment/compose/samples/FragmentComposeSamples.kt
M fragment/fragment-compose/src/androidTest/AndroidManifest.xml
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/AndroidFragmentTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRecreateTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/FragmentRemoveTest.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/SimpleEditTextFragment.kt
A fragment/fragment-compose/src/androidTest/java/androidx/fragment/compose/test/EmptyTestActivity.kt
A fragment/fragment-compose/src/androidTest/res/layout/content.xml
A fragment/fragment-compose/src/androidTest/res/layout/sample_edit_test_layout.xml
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/AndroidFragment.kt
A fragment/fragment-compose/src/main/java/androidx/fragment/compose/FragmentState.kt
M fragment/fragment/api/current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentTransaction.java
M settings.gradle

https://android-review.googlesource.com/2989182

Issue 300280229