ModalBottomSheet in landscape does not draw edge to edge [300280229]

Verified

Bug

Status Update

No update yet.

Description

jb...@physitrack.com

created issue #1

Sep 14, 2023 09:32AM

Jetpack Compose version: BOM 2023.09.00 Jetpack Compose component used: Material3 Android Studio Build: #AI-223.8836.35.2231.10671973 Kotlin version: 1.9.10

Steps to Reproduce or Code Sample to Reproduce:

Have a sample code like this with edge-to-edge enabled:

class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        WindowCompat.setDecorFitsSystemWindows(window, false)

        setContent {
            val view = LocalView.current

            LaunchedEffect(Unit) {
                window?.statusBarColor = Color.Transparent.toArgb()
                window?.navigationBarColor = Color.Transparent.toArgb()
                window?.let { WindowCompat.getInsetsController(it, view) }
                    ?.let {
                        it.isAppearanceLightStatusBars = true
                        it.isAppearanceLightNavigationBars = true
                    }
            }

            MyApplicationTheme {
                ModalBottomSheet(
                    modifier = Modifier.navigationBarsPadding(),
                    windowInsets = WindowInsets(0, 0, 0, 0),
                    onDismissRequest = { },
                ) {
                    Column(modifier = Modifier.height(200.dp)) {

                    }
                }
            }
        }
    }
}

Have system navigation using buttons not gestures
Open the app and rotate the phone to landscape
You would expect the scrim to be displayed edge-to-edge but the modal is cut on the right. Most probably by some incorrectly applied window insets.

Please see attached screenshot

Screenshot_20230914_112338.png

38 KB

View

Download

Comments

se...@google.com <se...@google.com> #2Mar 25, 2024 07:25PM

Reassigned to se...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

jb...@physitrack.com <jb...@physitrack.com> #3Mar 26, 2024 07:24AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Apr 22, 2024 12:07PM

Project: platform/frameworks/support
Branch: androidx-main

commit 33c32f65dd7879954cfa7a46a76eb959c977e291
Author: Jose Figueroa <serniebanders@google.com>
Date: Tue Mar 19 17:08:01 2024

[M3][BottomSheet] Migrate bottom sheet to dialog implementation from popup.

Dialog provides access to the new window created, which allows for system bars styling, setDecorFitsSystemWindows for edge to edge functionality, and unconsumed window insets for proper content padding.

Bug: 274872542
Bug: 300280229
Bug: 290893168
Test: "Existing tests now check for dialog, toggle decorFitsSystemWindows for edge to edge. Added Unit Test for content window inset consumption. Manual testing on API 28, 31, 33, 34 on Pixel 4a, 7, 8, Tablet, and Samsung Galaxy S24"
RelNote: "ModalBottomSheet more accurately draws scrim over status bar when edge to edge is enabled. Modal bottom sheet content can now consume window insets, allowing for visible content above navigation bar. ModalBottomSheet parameter windowInsets renamed to contentWindowInsets to specify where the insets will be applied, these are no longer tied to window logic. contentWindowInsets type has been changed to a function which returns WindowInsets, to allow it to be resolved within its new window."
Change-Id: I39630f2d9a1b159ef27fa62750ffa26b00e078a0

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/ui/common/CatalogScaffold.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
A compose/material3/material3/src/main/res/values-v30/styles.xml
A compose/material3/material3/src/main/res/values/styles.xml

https://android-review.googlesource.com/3007166

se...@google.com <se...@google.com> Jul 29, 2024 07:44PM

Verified by se...@google.com.

ar...@physitrack.com <ar...@physitrack.com> #5Sep 6, 2024 09:55AM

Is this included in Compose 1.7.0?

Issue 300280229