Fixed
Status Update
Comments
ba...@gmail.com <ba...@gmail.com> #2
Comment has been deleted.
ba...@gmail.com <ba...@gmail.com> #3
cc...@google.com <cc...@google.com> #4
targetPackageOnly needs to be updated to understand process_tracks in addition to thread_tracks. E.g. could union the current result with one around process_tracks, something like:
select * from slice
inner join process_track on slice.track_id = process_track.id
inner join process USING(upid)
where slice.id=23647
ml...@google.com <ml...@google.com> #5
I was thinking, since this is already in beta03
, should we treat it as a bug and not addition to 1.3?
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024
TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.
Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
https://android-review.googlesource.com/3023506
Branch: androidx-main
commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024
TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.
Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt
na...@google.com <na...@google.com> #7
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.3.0-alpha03
Description
Component used: Macrobench ToT, androidx.tracing alpha 1.3.0-alpha02
When you add an asynchronous trace section to the app with
Trace.beginAsyncSection
, it doesn't contain information about the thread and thus the default parametertargetPackageOnly=true
ofTraceSectionMetric
won't find this section.For example, this trace from FTL contains
InteropTransitionToFirstDraw
When checking the slice without the
thread_track
, it's returned properlyBut when simulating the
targetPackageOnly = true
query, it's not found because of thethread_track
Can we improve this query somehow? Maybe if we used
LEFT JOIN
and check if the slice actually have any thread data then we can filter based on package?