Trace.beginAsyncSection is not captured with TraceSectionMetric with targetPackageOnly = true [300434906]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Sep 14, 2023 01:16PM

Component used: Macrobench ToT, androidx.tracing alpha 1.3.0-alpha02

When you add an asynchronous trace section to the app with Trace.beginAsyncSection, it doesn't contain information about the thread and thus the default parameter targetPackageOnly=true of TraceSectionMetric won't find this section.

For example, this trace from FTL contains InteropTransitionToFirstDraw

When checking the slice without the thread_track, it's returned properly

SELECT * FROM slice WHERE slice.id=23647

But when simulating the targetPackageOnly = true query, it's not found because of the thread_track

SELECT * from slice  
   INNER JOIN thread_track on slice.track_id = thread_track.id
   INNER JOIN thread USING(utid)
   INNER JOIN process USING(upid)
WHERE slice.id=23647

Can we improve this query somehow? Maybe if we used LEFT JOIN and check if the slice actually have any thread data then we can filter based on package?

Comments

ba...@gmail.com <ba...@gmail.com> #2Sep 14, 2023 01:31PM

Comment has been deleted.

Message last modified on Sep 14, 2023 01:31PM

ba...@gmail.com <ba...@gmail.com> #3Sep 14, 2023 01:31PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

cc...@google.com <cc...@google.com> #4Sep 14, 2023 03:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

Thu Sep 14 2023 08:42:29 GMT-0700 (Pacific Daylight Time).png

52 KB

View

Download

ml...@google.com <ml...@google.com> #5Sep 19, 2023 05:03AM

I was thinking, since this is already in beta03, should we treat it as a bug and not addition to 1.3?

ra...@google.com <ra...@google.com> Apr 2, 2024 09:30PM

Accepted by ra...@google.com.

ap...@google.com <ap...@google.com> #6Apr 3, 2024 07:55PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024

TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.

* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.

Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1

M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/3023506

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha03