Trace.beginAsyncSection is not captured with TraceSectionMetric with targetPackageOnly = true [300434906]

Fixed

Bug

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Sep 14, 2023 01:16PM

Component used: Macrobench ToT, androidx.tracing alpha 1.3.0-alpha02

When you add an asynchronous trace section to the app with Trace.beginAsyncSection, it doesn't contain information about the thread and thus the default parameter targetPackageOnly=true of TraceSectionMetric won't find this section.

For example, this trace from FTL contains InteropTransitionToFirstDraw

When checking the slice without the thread_track, it's returned properly

SELECT * FROM slice WHERE slice.id=23647

But when simulating the targetPackageOnly = true query, it's not found because of the thread_track

SELECT * from slice  
   INNER JOIN thread_track on slice.track_id = thread_track.id
   INNER JOIN thread USING(utid)
   INNER JOIN process USING(upid)
WHERE slice.id=23647

Can we improve this query somehow? Maybe if we used LEFT JOIN and check if the slice actually have any thread data then we can filter based on package?

Comments

ba...@gmail.com <ba...@gmail.com> #2Sep 14, 2023 01:31PM

Comment has been deleted.

Message last modified on Sep 14, 2023 01:31PM

ba...@gmail.com <ba...@gmail.com> #3Sep 14, 2023 01:31PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Marcello Albano <maralb@google.com>
Link: https://android-review.googlesource.com/3303459

Added override for debuggable and profileable for benchmark builds in bpgp

Expand for full commit details

Added override for debuggable and profileable for benchmark builds in bpgp

Test: ./gradlew :benchmark:benchmark-baseline-profile-gradle-plugin:test
Bug: 369213505
Relnote: "isProfileable is always overridden in benchmark builds,
  and isDebuggable is also now always overridden in both benchmark and
  nonMinified (baseline profile capture) builds."
Change-Id: I487fa71083921682173f04fcbb477be5baf165f8

Files:

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/apptarget/BaselineProfileAppTargetPluginTest.kt

Hash: 1906bbe52ba7ccb9ca0e1c1d6de33e7c91b5c6f0
Date: Fri Oct 11 10:07:06 2024

cc...@google.com <cc...@google.com> #4Sep 14, 2023 03:43PM

I've landed a change that will set the following properties also when the benchmark build type already exists:

isJniDebuggable = false
isDebuggable = false
isProfileable = true

As well as the following for agp 8.0:

isDebuggable = false

I'm going ahead and closing this - if you've further questions please answer here and will reopen. Thanks.

Thu Sep 14 2023 08:42:29 GMT-0700 (Pacific Daylight Time).png

52 KB

View

Download

ml...@google.com <ml...@google.com> #5Sep 19, 2023 05:03AM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.4.0-alpha04

ra...@google.com <ra...@google.com> Apr 2, 2024 09:30PM

Accepted by ra...@google.com.

ap...@google.com <ap...@google.com> #6Apr 3, 2024 07:55PM

Marked as fixed.

Since release signing config is used by default instead of debug is not mentioned in release notes - maybe this is a bug?

Cause the last time I found it mentioned in the release notes was in version 1.1

signingConfig.debug is used as the default signing config (b/153583269)

So, if the switch to the release one indeed happened - maybe it's an issue?

na...@google.com <na...@google.com> #7Apr 17, 2024 05:17PM

The new build types should inherit the certificates from the release build type, unless none is specified in which case debug is used: code link

This should be updated in the documentation, thanks for mentioning it. Will take care of updating it.