SQLite KMP [300660920] - Issue Tracker

In Progress

Project

Status Update

No update yet.

Description

da...@google.com

created issue #1

Sep 15, 2023 06:33PM

Master bug for making SQLite KMP

Comments

ap...@google.com <ap...@google.com> #2Dec 12, 2023 07:48PM

To work around this for our CHIPS tests, we had to use a java bridge and report what was available in javascript. But this doesn't fully cover http cookies which is an issue.

https://crrev.com/c/5250507

We should fix this when we implement this CookieManager API.

ap...@google.com <ap...@google.com> #3Dec 12, 2023 07:48PM

This issue was migrated from

crbug.com/chromium/1523964?no_tracker_redirect=1

[Monorail components added to Component Tags custom field.]

ap...@google.com <ap...@google.com> #4Dec 13, 2023 02:22PM

Another issue is that shouldInterceptRequest does not include the cookie header which forces developers to query it at the time of requests. We should include this as well.

Because this will likely require a breaking change, I will first experiment with this behind a flag: https://crrev.com/c/5616051

ap...@google.com <ap...@google.com> #5Dec 13, 2023 02:22PM

Project: chromium/src
Branch: main

commit 041b6a3c262e0ee8656e42fa6aa9cf32362fa9f2
Author: Rupert Ben Wiser <bewise@chromium.org>
Date: Fri Jun 28 18:08:13 2024

webview: Add cookie headers to shouldInterceptRequest

The problem is that shouldInterceptRequest
gets fired before the net stack ultimately adds the
cookie header. This means that Android developers have to
separately query the cookie manager for headers but as we introduce
new changes to the cookie header, the CookieManager API
can't keep up.

The one issue with this approach is that we are of course
having to try replicate what the network stack would be doing.
In this case, I am matching the partitioning but there
could be other cookie behaviors we need to preserve.
We are somewhat forced to maintain this already for WebView's
restricted cookie manager so we can share the policy which lowers
the maintenance burden a bit.

We also discovered that Set-Cookie doesn't have an effect with
shouldInterceptRequest either for similar reasons.
The Set-Cookie header is not allowed to be persisted over the mojo
calls so we need to return that value to our URL Loader factory with a
simple callback.

Bug: 41496912
Change-Id: Iff5cc37ab0f678c59503cc9d69e3c05cd4ccdf4a
Reviewed-on:

https://chromium-review.googlesource.com/c/chromium/src/+/5616051
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Commit-Queue: Rupert Wiser <bewise@chromium.org>
Auto-Submit: Rupert Wiser <bewise@chromium.org>
Reviewed-by: Mike Taylor <miketaylr@chromium.org>
Reviewed-by: Dylan Cutler <dylancutler@google.com>
Cr-Commit-Position: refs/heads/main@{#1321072}

M android_webview/browser/aw_content_browser_client.cc
M android_webview/browser/aw_cookie_access_policy.h
M android_webview/browser/network_service/aw_proxying_url_loader_factory.cc
M android_webview/browser/network_service/aw_proxying_url_loader_factory.h
M android_webview/common/aw_switches.cc
M android_webview/common/aw_switches.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M components/embedder_support/android/util/android_stream_reader_url_loader.cc
M components/embedder_support/android/util/android_stream_reader_url_loader.h

https://chromium-review.googlesource.com/5616051

ap...@google.com <ap...@google.com> #6Dec 13, 2023 06:45PM

Project: chromium/src
Branch: main
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6237015

[WV] Determine if partitioned cookies are not sent to apps.

Expand for full commit details

[WV] Determine if partitioned cookies are not sent to apps. 
 
This allows an investigation into how often partitioned cookies are not 
passed to apps. Using CookieManager::SiteHasCookieInOtherPartition, this 
indicates whether a site's cookies, with one partition key, also has the 
same cookies with a different cookie partition key. This will prove that 
there are cookies being omitted on a given site due to the partitioning. 
 
Co-Authors: bewise, avvall 
Bug: 41496912 
Change-Id: I3698788038afc16c23bb05f6e7f485394433fd07 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237015 
Reviewed-by: Peter Beverloo <peter@chromium.org> 
Reviewed-by: Elly FJ <ellyjones@chromium.org> 
Reviewed-by: Maks Orlovich <morlovich@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1417004}

Files:

M android_webview/browser/aw_feature_map.cc
M android_webview/browser/cookie_manager.cc
M android_webview/browser/cookie_manager.h
M android_webview/common/aw_features.cc
M android_webview/common/aw_features.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M services/network/cookie_manager.cc
M services/network/cookie_manager.h
M services/network/public/mojom/cookie_manager.mojom
M services/network/test/test_cookie_manager.h
M tools/metrics/histograms/metadata/android/histograms.xml

Hash: cbebd148e6898552bdd91af1c63c92b2de40beed
Date: Thu Feb 06 13:52:04 2025

ap...@google.com <ap...@google.com> #7Dec 13, 2023 06:45PM

Project: chromium/src
Branch: main
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6240130

[WV] Add test config for WebViewPartitionedCookiesExcluded

Expand for full commit details

[WV] Add test config for WebViewPartitionedCookiesExcluded 
 
This adds a JSON config entry for WebViewPartitionedCookiesExcluded so 
that A/B experimentation can occur for this feature. This flag was added 
in `[WV] Determine if partitioned cookies are not sent to apps. | 
https://chromium-review.googlesource.com/c/chromium/src/+/6237015`. 
 
Test: N/A 
Bug: 41496912 
Change-Id: I29c0a210364734675331a3bf180ee0b33b7c45cb 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240130 
Reviewed-by: Ben Pastene <bpastene@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Commit-Position: refs/heads/main@{#1417090}

Files:

M testing/variations/fieldtrial_testing_config.json

Hash: ad82f6bbd357a122ba932a0d3ec711551561616f
Date: Thu Feb 06 16:49:55 2025

ap...@google.com <ap...@google.com> #8Dec 13, 2023 06:45PM

CLs listed at #6 and #7 are included in Canary #135.0.7003.0+, please update the bug with canary result on Monday morning.

So we can review it for M134 (+mcirlanaru@ too)

ap...@google.com <ap...@google.com> #9Dec 13, 2023 06:45PM

FYI govind@: metrics (as added by CL listed at #6) verified successfully in Canary.

ap...@google.com <ap...@google.com> #10Dec 19, 2023 09:27PM

The NextAction date has arrived: 2025-02-10 To opt-out from this automation rule, please add Optout-Blintz-Nextaction-Alert to the "Chromium Labels" custom field.

ap...@google.com <ap...@google.com> #11Jan 17, 2024 03:55PM

M134 branch 6998 merge approved for both CLs listed at #6 and #7 per comment #9 and per offline chat with Miahi.

ap...@google.com <ap...@google.com> #12Apr 11, 2024 10:29PM

Project: chromium/src
Branch: refs/branch-heads/6998
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6249545

[M134] [WV] Determine if partitioned cookies are not sent to apps.

Expand for full commit details

[M134] [WV] Determine if partitioned cookies are not sent to apps. 
 
This allows an investigation into how often partitioned cookies are not 
passed to apps. Using CookieManager::SiteHasCookieInOtherPartition, this 
indicates whether a site's cookies, with one partition key, also has the 
same cookies with a different cookie partition key. This will prove that 
there are cookies being omitted on a given site due to the partitioning. 
 
(cherry picked from commit cbebd148e6898552bdd91af1c63c92b2de40beed) 
 
Co-Authors: bewise, avvall 
Bug: 41496912 
Change-Id: I3698788038afc16c23bb05f6e7f485394433fd07 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6237015 
Reviewed-by: Peter Beverloo <peter@chromium.org> 
Reviewed-by: Elly FJ <ellyjones@chromium.org> 
Reviewed-by: Maks Orlovich <morlovich@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Original-Commit-Position: refs/heads/main@{#1417004} 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249545 
Reviewed-by: Nate Fischer <ntfschr@chromium.org> 
Commit-Queue: Krishna Govind <govind@chromium.org> 
Owners-Override: Krishna Govind <govind@chromium.org> 
Reviewed-by: Krishna Govind <govind@chromium.org> 
Cr-Commit-Position: refs/branch-heads/6998@{#387} 
Cr-Branched-From: de9c6fafd8ae5c6ea0438764076ca7d04a0b165d-refs/heads/main@{#1415337}

Files:

M android_webview/browser/aw_feature_map.cc
M android_webview/browser/cookie_manager.cc
M android_webview/browser/cookie_manager.h
M android_webview/common/aw_features.cc
M android_webview/common/aw_features.h
M android_webview/java/src/org/chromium/android_webview/common/ProductionSupportedFlagList.java
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java
M services/network/cookie_manager.cc
M services/network/cookie_manager.h
M services/network/public/mojom/cookie_manager.mojom
M services/network/test/test_cookie_manager.h
M tools/metrics/histograms/metadata/android/histograms.xml

Hash: 16aba54fcf062cfe3784b35d0230330f6e4dc3ba
Date: Mon Feb 10 10:17:21 2025

ap...@google.com <ap...@google.com> #13Jan 23, 2025 01:52PM

Project: chromium/src
Branch: refs/branch-heads/6998
Author: Adam Walls <avvall@google.com>
Link: https://chromium-review.googlesource.com/6249204

[M134] [WV] Add test config for WebViewPartitionedCookiesExcluded

Expand for full commit details

[M134] [WV] Add test config for WebViewPartitionedCookiesExcluded 
 
This adds a JSON config entry for WebViewPartitionedCookiesExcluded so 
that A/B experimentation can occur for this feature. This flag was added 
in `[WV] Determine if partitioned cookies are not sent to apps. | 
https://chromium-review.googlesource.com/c/chromium/src/+/6237015`. 
 
(cherry picked from commit ad82f6bbd357a122ba932a0d3ec711551561616f) 
 
Test: N/A 
Bug: 41496912 
Change-Id: I29c0a210364734675331a3bf180ee0b33b7c45cb 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6240130 
Reviewed-by: Ben Pastene <bpastene@chromium.org> 
Commit-Queue: Adam Walls <avvall@chromium.org> 
Cr-Original-Commit-Position: refs/heads/main@{#1417090} 
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6249204 
Reviewed-by: Krishna Govind <govind@chromium.org> 
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> 
Reviewed-by: Nate Fischer <ntfschr@chromium.org> 
Owners-Override: Krishna Govind <govind@chromium.org> 
Commit-Queue: Krishna Govind <govind@chromium.org> 
Cr-Commit-Position: refs/branch-heads/6998@{#397} 
Cr-Branched-From: de9c6fafd8ae5c6ea0438764076ca7d04a0b165d-refs/heads/main@{#1415337}

Files:

M testing/variations/fieldtrial_testing_config.json

Hash: 3c33baad1d076a7fbf7a9c490cc4755f3bcc0bf5
Date: Mon Feb 10 11:52:17 2025

ap...@google.com <ap...@google.com> #14Jan 30, 2025 07:00PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <danysantiago@google.com>
Link: https://android-review.googlesource.com/3470832

Move Room and SQLite (KMP) to beta

Expand for full commit details

Move Room and SQLite (KMP) to beta 
 
Bug: 299168035 
Bug: 300660920 
Test: n/a 
Change-Id: I41e1bee06bc65264673aab95ee12a2cb84938bae

Files:

M libraryversions.toml
A room/room-common/api/2.7.0-beta01.txt
A room/room-common/api/restricted_2.7.0-beta01.txt
A room/room-common/bcv/native/2.7.0-beta01.txt
A room/room-external-antlr/api/2.7.0-beta01.txt
A room/room-external-antlr/api/restricted_2.7.0-beta01.txt
A room/room-guava/api/2.7.0-beta01.txt
A room/room-guava/api/res-2.7.0-beta01.txt
A room/room-guava/api/restricted_2.7.0-beta01.txt
A room/room-ktx/api/2.7.0-beta01.txt
A room/room-ktx/api/res-2.7.0-beta01.txt
A room/room-ktx/api/restricted_2.7.0-beta01.txt
A room/room-migration/api/2.7.0-beta01.txt
A room/room-migration/api/restricted_2.7.0-beta01.txt
A room/room-migration/bcv/native/2.7.0-beta01.txt
A room/room-paging-guava/api/2.7.0-beta01.txt
A room/room-paging-guava/api/res-2.7.0-beta01.txt
A room/room-paging-guava/api/restricted_2.7.0-beta01.txt
A room/room-paging-rxjava2/api/2.7.0-beta01.txt
A room/room-paging-rxjava2/api/res-2.7.0-beta01.txt
A room/room-paging-rxjava2/api/restricted_2.7.0-beta01.txt
A room/room-paging-rxjava3/api/2.7.0-beta01.txt
A room/room-paging-rxjava3/api/res-2.7.0-beta01.txt
A room/room-paging-rxjava3/api/restricted_2.7.0-beta01.txt
A room/room-paging/api/2.7.0-beta01.txt
A room/room-paging/api/res-2.7.0-beta01.txt
A room/room-paging/api/restricted_2.7.0-beta01.txt
A room/room-paging/bcv/native/2.7.0-beta01.txt
A room/room-runtime/api/2.7.0-beta01.txt
A room/room-runtime/api/res-2.7.0-beta01.txt
A room/room-runtime/api/restricted_2.7.0-beta01.txt
A room/room-runtime/bcv/native/2.7.0-beta01.txt
A room/room-rxjava2/api/2.7.0-beta01.txt
A room/room-rxjava2/api/res-2.7.0-beta01.txt
A room/room-rxjava2/api/restricted_2.7.0-beta01.txt
A room/room-rxjava3/api/2.7.0-beta01.txt
A room/room-rxjava3/api/res-2.7.0-beta01.txt
A room/room-rxjava3/api/restricted_2.7.0-beta01.txt
A room/room-testing/api/2.7.0-beta01.txt
A room/room-testing/api/res-2.7.0-beta01.txt
A room/room-testing/api/restricted_2.7.0-beta01.txt
A room/room-testing/bcv/native/2.7.0-beta01.txt
A sqlite/sqlite-bundled/api/2.5.0-beta01.txt
A sqlite/sqlite-bundled/api/res-2.5.0-beta01.txt
A sqlite/sqlite-bundled/api/restricted_2.5.0-beta01.txt
A sqlite/sqlite-bundled/bcv/native/2.5.0-beta01.txt
A sqlite/sqlite-framework/api/2.5.0-beta01.txt
A sqlite/sqlite-framework/api/res-2.5.0-beta01.txt
A sqlite/sqlite-framework/api/restricted_2.5.0-beta01.txt
A sqlite/sqlite-framework/bcv/native/2.5.0-beta01.txt
A sqlite/sqlite-ktx/api/2.5.0-beta01.txt
A sqlite/sqlite-ktx/api/res-2.5.0-beta01.txt
A sqlite/sqlite-ktx/api/restricted_2.5.0-beta01.txt
A sqlite/sqlite/api/2.5.0-beta01.txt
A sqlite/sqlite/api/res-2.5.0-beta01.txt
A sqlite/sqlite/api/restricted_2.5.0-beta01.txt
A sqlite/sqlite/bcv/native/2.5.0-beta01.txt

Hash: 90099de424174ebef1c53fc3eddaa6d3544b7b4b
Date: Thu Jan 30 13:25:12 2025

da...@google.com <da...@google.com> Feb 27, 2025 02:28PM

Accepted by da...@google.com.

Issue 300660920

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Dec 12, 2023 07:48PM

ap...@google.com <ap...@google.com> #3Dec 12, 2023 07:48PM

ap...@google.com <ap...@google.com> #4Dec 13, 2023 02:22PM

ap...@google.com <ap...@google.com> #5Dec 13, 2023 02:22PM

ap...@google.com <ap...@google.com> #6Dec 13, 2023 06:45PM

ap...@google.com <ap...@google.com> #7Dec 13, 2023 06:45PM

ap...@google.com <ap...@google.com> #8Dec 13, 2023 06:45PM

ap...@google.com <ap...@google.com> #9Dec 13, 2023 06:45PM

ap...@google.com <ap...@google.com> #10Dec 19, 2023 09:27PM

ap...@google.com <ap...@google.com> #11Jan 17, 2024 03:55PM

ap...@google.com <ap...@google.com> #12Apr 11, 2024 10:29PM

ap...@google.com <ap...@google.com> #13Jan 23, 2025 01:52PM

ap...@google.com <ap...@google.com> #14Jan 30, 2025 07:00PM

da...@google.com <da...@google.com> Feb 27, 2025 02:28PM

Add comment

Issue metadata