Fixed
Status Update
Comments
ma...@google.com <ma...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit c9cf25062fed6a75c01e6fb7bad692ad6320a6e9
Author: Leticia Santos <leticiars@google.com>
Date: Wed Dec 06 13:33:47 2023
[NavigationSuiteScaffold] Fixed navigation component filling entire screen when root surface has modifier.fillMaxSize
When using Surface with fillMaxSize it tries to fill its entire available space with the first composable it finds, but wrapping that composable in a Box prevents that.
Test: manually tested
Bug: 312664933
Change-Id: Ifd23d070ab09f1750384d42ef43a5dc252fac560
M compose/material3/material3-adaptive-navigation-suite/src/commonMain/kotlin/androidx/compose/material3/adaptive/navigation-suite/NavigationSuiteScaffold.kt
https://android-review.googlesource.com/2861890
Branch: androidx-main
commit c9cf25062fed6a75c01e6fb7bad692ad6320a6e9
Author: Leticia Santos <leticiars@google.com>
Date: Wed Dec 06 13:33:47 2023
[NavigationSuiteScaffold] Fixed navigation component filling entire screen when root surface has modifier.fillMaxSize
When using Surface with fillMaxSize it tries to fill its entire available space with the first composable it finds, but wrapping that composable in a Box prevents that.
Test: manually tested
Bug: 312664933
Change-Id: Ifd23d070ab09f1750384d42ef43a5dc252fac560
M compose/material3/material3-adaptive-navigation-suite/src/commonMain/kotlin/androidx/compose/material3/adaptive/navigation-suite/NavigationSuiteScaffold.kt
sg...@google.com <sg...@google.com>
ap...@google.com <ap...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3-adaptive-navigation-suite:1.0.0-alpha02
androidx.compose.material3:material3-adaptive-navigation-suite-android:1.0.0-alpha02
androidx.compose.material3:material3-adaptive-navigation-suite-desktop:1.0.0-alpha02
sg...@google.com <sg...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit f6f510999615b25e0a1c118f1136a40bdef6f31f
Author: Leticia Santos <leticiars@google.com>
Date: Tue Jan 23 15:23:34 2024
[NavigationSuiteScaffold] Add some tests.
These tests are related to aosp/2861890
Test: self
Bug: 312664933
Change-Id: I63bda11216f0fc36927ce0b694b82490203ead03
A compose/material3/material3-adaptive-navigation-suite/src/androidInstrumentedTest/kotlin/androidx/compose/material3/adaptive-navigation-suite/NavigationSuiteScaffoldTest.kt
https://android-review.googlesource.com/2924390
Branch: androidx-main
commit f6f510999615b25e0a1c118f1136a40bdef6f31f
Author: Leticia Santos <leticiars@google.com>
Date: Tue Jan 23 15:23:34 2024
[NavigationSuiteScaffold] Add some tests.
These tests are related to aosp/2861890
Test: self
Bug: 312664933
Change-Id: I63bda11216f0fc36927ce0b694b82490203ead03
A compose/material3/material3-adaptive-navigation-suite/src/androidInstrumentedTest/kotlin/androidx/compose/material3/adaptive-navigation-suite/NavigationSuiteScaffoldTest.kt
Description
Jetpack Compose version: 1.5.1 (androidx.compose:compose-bom:2023.09.00)
Jetpack Compose component used: androidx.compose.material3:material3:1.2.0-alpha07
Android Studio Build: Android Studio Giraffe | 2022.3.1 Patch 1
Kotlin version: 1.9.10
If you place DropdownMenu inside title of TopAppBar and there is a composable with fillMaxHeight Modifier, then the DropdownMenu will not be placed under the TopAppBar, but under the center of the Scaffold content. The workaround is to use height(64.dp) Modifier instead of fillMaxHeight().
Code sample:
Also you can download the sample project.