TopAppBarLayout constraints can be inconsistent with its height - causing DropdownMenu to be mispositioned [300953236]

Fixed

Bug

Status Update

No update yet.

Description

er...@gmail.com

created issue #1

Sep 18, 2023 11:01PM

Jetpack Compose version: 1.5.1 (androidx.compose:compose-bom:2023.09.00)

Jetpack Compose component used: androidx.compose.material3:material3:1.2.0-alpha07

Android Studio Build: Android Studio Giraffe | 2022.3.1 Patch 1

Kotlin version: 1.9.10

If you place DropdownMenu inside title of TopAppBar and there is a composable with fillMaxHeight Modifier, then the DropdownMenu will not be placed under the TopAppBar, but under the center of the Scaffold content. The workaround is to use height(64.dp) Modifier instead of fillMaxHeight().

Code sample:

Scaffold(
    topBar = {
        TopAppBar(
            title = {
                var expanded by remember { mutableStateOf(false) }
                Box(
                    contentAlignment = Alignment.Center,
                    modifier = Modifier
                        .fillMaxHeight() // replace it with height(64.dp) to workaround
                        .clickable { expanded = true }
                ) {
                    Text(text = "Click here")
                }
                DropdownMenu(
                    expanded = expanded,
                    onDismissRequest = { expanded = false }
                ) {
                    ...
                }
            }
        )
    }
) { paddingValues ->
    ...
}

Also you can download the sample project.

Screenshot_1695076355.png

55 KB

View

Download

Screenshot_1695076367.png

55 KB

View

Download

DropdownMenuInTopAppBar.zip

66 KB

Download

Comments

ma...@google.com <ma...@google.com> #2Sep 20, 2023 07:44PM

Project: platform/frameworks/support
Branch: androidx-main

commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023

[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.

This enables standardBottomSheet to implement a fully Hidden state should the user choose to.

Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape

Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d

M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt

https://android-review.googlesource.com/2500395

sg...@google.com <sg...@google.com> Mar 13, 2024 11:36PM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #3Mar 25, 2024 07:46PM

Marked as fixed.

Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.

sg...@google.com <sg...@google.com> #4Mar 25, 2024 08:00PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-beta02

Issue 300953236

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Sep 20, 2023 07:44PM

sg...@google.com <sg...@google.com> Mar 13, 2024 11:36PM

ap...@google.com <ap...@google.com> #3Mar 25, 2024 07:46PM

sg...@google.com <sg...@google.com> #4Mar 25, 2024 08:00PM

Add comment

Issue metadata