SoftwareKeyboardController.show() shows keyboard even though no input is focused, acting like a hardware keyboard [301477279]

Fixed

Bug

Status Update

No update yet.

Description

el...@reaktor.com

created issue #1

Sep 21, 2023 08:22PM

Jetpack Compose version: 1.6.0-alpha06
Jetpack Compose component used: SoftwareKeyboardController
Kotlin version: 1.9.10

Steps to Reproduce or Code Sample to Reproduce:

val scope = rememberCoroutineScope()
val fr = remember { FocusRequester() }
val fr2 = remember { FocusRequester() }
var value by remember { mutableStateOf("testing") }
var isFocused by remember { mutableStateOf(false) }
LaunchedEffect(Unit) { fr.requestFocus() }
Row {
    BasicTextField(modifier = Modifier.focusRequester(fr), value = value, onValueChange = { value = it })
    Box(
        Modifier
            .size(300.dp)
            .focusRequester(fr2)
            .background(if (isFocused) Color.Green else Color.Cyan)
            .onFocusChanged { isFocused = it.isFocused }
            .focusable()
    )
    val kc = LocalSoftwareKeyboardController.current
    Box(
        Modifier
            .clickable {
                scope.launch {
                    fr2.requestFocus()
                    delay(200.milliseconds)
                    kc?.hide()
                    delay(200.milliseconds)
                    kc?.show()
                }
            }
            .size(300.dp)
            .background(Color.Magenta))
}

Press the magenta Box
Observe focus move to the green Box but keyboard still toggling

Screen_recording_20230921_132122.webm

2 MB

Download

Comments

kl...@google.com <kl...@google.com> Oct 23, 2023 04:11PM

Reassigned to kl...@google.com.

kl...@google.com <kl...@google.com> #2Oct 25, 2023 06:12PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 6856d4b8fe5fbd6d5d2926ca6ced38f286751505
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Aug 17 12:53:32 2022

Renaming focusDirections In & Out to Enter & Exit

We want to add custom focus properties for In & Out,
but we can't do that since in is a reserved keyword in kotlin.
This CL renames the In and Out focus directions to Enter and Exit.

Bug: 183746982
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalEnterTest
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalEnterTest
Relnote: Renamed FocusDirection.In and FocusDirection.Out to FocusDirection.Enter and FocusDirection.Exit
Change-Id: Ia4262d2f8edc3ec36d2edc9ed2858895971ba33c

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalExitTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusSearchNonPlacedItemsTest.kt
M compose/ui/ui/api/restricted_current.ignore
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusGroupTest.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/1.3.0-beta02.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalEnterTest.kt
M compose/ui/ui/api/current.ignore
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/api/public_plus_experimental_1.3.0-beta02.txt
M compose/ui/ui/api/restricted_1.3.0-beta02.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/KeyEventToFocusDirectionTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOrderModifier.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/list/LazyListFocusMoveTest.kt
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2189001

bo...@gmail.com <bo...@gmail.com> #3Nov 16, 2023 10:08AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8bbfa2fd7f3cb0f386c186b5df840513d8246d6b
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Aug 29 16:16:07 2022

Added custom focus properties for enter and exit

Added experimental API for users to specify a custom enter and exit
behavior when focus enters/exits a focus group.

Bug: 183746982
Relnote: "Added experimental API for users to specify a custom enter and exit behavior when focus enters/exits a focus group."
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalEnterTest
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalExitTest
Change-Id: I5f3f9e1c20494f3ee0d6484854c3d50485422ba3

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalExitTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTraversal.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalInitialFocusTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalEnterTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusProperties.kt
M compose/ui/ui/api/public_plus_experimental_1.3.0-beta02.txt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/FocusSamples.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusOrderModifier.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusTestUtils.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CustomFocusTraversalTest.kt

https://android-review.googlesource.com/2201257

el...@reaktor.com <el...@reaktor.com> #4Nov 19, 2023 11:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit d496b3e091b18ddb0c179803ef1504ce5a715cc4
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Sep 01 01:27:59 2022

Add support for implicit focus enter and exit

We perform an implicit Enter in the following cases:
1. The user calls requestFocus() on a focus group.
2. The user navigates to a focus group during focus search.

We perform an implicit Exit in the following case:
1. The user reaches the end of a focus group and
focus search takes the user outside the focus group.

Bug: 183746982
Fix: 183746982
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalImplicitEnterTest
Test: ./gradlew compose:ui:ui:cC -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.TwoDimensionalFocusTraversalImplicitExitTest
Change-Id: Ibd1b28c6e401490e72dc232f166449f0a6e34e10

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalExitTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitExitTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/FocusRequesterTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalImplicitEnterTest.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusTraversalTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusRequester.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/ExplicitEnterExitWithCustomFocusEnterExitDemo.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusTransactions.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/TwoDimensionalFocusSearch.kt

https://android-review.googlesource.com/2202586

Issue 301477279

Description

Issue summary

Comments

kl...@google.com <kl...@google.com> Oct 23, 2023 04:11PM

kl...@google.com <kl...@google.com> #2Oct 25, 2023 06:12PM

bo...@gmail.com <bo...@gmail.com> #3Nov 16, 2023 10:08AM

el...@reaktor.com <el...@reaktor.com> #4Nov 19, 2023 11:53AM

Add comment

Issue metadata