TraceSectionMetric optional custom name [301892382]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Sep 25, 2023 07:58AM

TraceSectionMetric reports name as the sectionName + Ms or Count (in case of Mode.Sum).

Sometimes this might be super long and breaks standard horizontal size:

JIT compiling %com.google.composeviewbenchmarks.target%Ms      min      30.7,   median      97.7,   max     204.1

What do you think of adding optional metricName parameter to reduce this and give developers the option to define the name.

Pros:

shorter names easily glanceable
if we're improving metrics as in b/300887146 you can define the names yourself

Potential issues:

conflicting names
renaming something and forgetting what it was in reality

Comments

cc...@google.com <cc...@google.com> #2Sep 26, 2023 04:34PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

ml...@google.com <ml...@google.com> #3Sep 27, 2023 08:22AM

yea i'll take it.

Message last modified on Sep 27, 2023 08:31AM

ml...@google.com <ml...@google.com> #4Dec 4, 2023 09:22AM

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

Message last modified on Dec 4, 2023 09:22AM

ap...@google.com <ap...@google.com> #5Dec 5, 2023 05:50PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

cc...@google.com <cc...@google.com> Jan 5, 2024 12:00AM

Marked as fixed.

pr...@google.com <pr...@google.com> #6Feb 21, 2024 07:32PM

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

Issue 301892382