TraceSectionMetric optional custom name [301892382]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Sep 25, 2023 07:58AM

TraceSectionMetric reports name as the sectionName + Ms or Count (in case of Mode.Sum).

Sometimes this might be super long and breaks standard horizontal size:

JIT compiling %com.google.composeviewbenchmarks.target%Ms      min      30.7,   median      97.7,   max     204.1

What do you think of adding optional metricName parameter to reduce this and give developers the option to define the name.

Pros:

shorter names easily glanceable
if we're improving metrics as in b/300887146 you can define the names yourself

Potential issues:

conflicting names
renaming something and forgetting what it was in reality

Comments

cc...@google.com <cc...@google.com> #2Sep 26, 2023 04:34PM

Thanks, i was able to reproduce. It's a bit odd because it happens only when flavors are specified and generation is for a single variant.

ml...@google.com <ml...@google.com> #3Sep 27, 2023 08:22AM

Found the issue, fix should be in the next 1.3 release.

Thank you!

Message last modified on Sep 27, 2023 08:31AM

ml...@google.com <ml...@google.com> #4Dec 4, 2023 09:22AM

Project: platform/frameworks/support
Branch: androidx-main

commit c16b952992febb4660bd9158d7c9813b5c9bbd87
Author: Marcello Albano <maralb@google.com>
Date: Mon Jun 03 13:13:02 2024

Ensure merge art and startup profiles always waits for profile generation

Test: added
Bug: 343086054
Change-Id: I623d65b8fedc7abb1d22fb2ca016582703f51176

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/consumer/BaselineProfileConsumerPluginTest.kt
M benchmark/integration-tests/baselineprofile-producer/src/main/java/androidx/benchmark/integration/baselineprofile/producer/BaselineProfileTest.kt

https://android-review.googlesource.com/3111647

Message last modified on Dec 4, 2023 09:22AM

ap...@google.com <ap...@google.com> #5Dec 5, 2023 05:50PM

Thanks. I also kindly ask you to escalate 342316793. For my team it's a very severe issue that causes problems when running baseline generation in CI env.

cc...@google.com <cc...@google.com> Jan 5, 2024 12:00AM

Marked as fixed.

pr...@google.com <pr...@google.com> #6Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-beta01

Issue 301892382